Skip to content

In new IO library, improve representation of FileMode #7785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catamorphism opened this issue Jul 14, 2013 · 2 comments
Closed

In new IO library, improve representation of FileMode #7785

catamorphism opened this issue Jul 14, 2013 · 2 comments

Comments

@catamorphism
Copy link
Contributor

See FIXME (formerly XXX) -- though I think the current data structure might be as good as we can get. (It could instead be a pair of "what to do if the file doesn't exist / what to do if the file exists", but we want to rule out some possible combinations.)

@olsonjeffery
Copy link
Contributor

I'm using this as part of #8655 .. I don't think it's that bad, tbh. But, yeah. open to suggestions.

You don't have to squint too hard to realize that this abstraction is derived from unix file mode flags passed to open(2). And our initial impl atop libuv also uses the same flags. So it's working pretty well, there. But will that always be the case for other underlying io frameworks?

@alexcrichton
Copy link
Member

Closing in favor of #2623, that bug is tagged and nominated, and it has essentially the same conclusion as this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants