Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put os::change_dir_locked somewhere else #7870

Closed
brson opened this issue Jul 18, 2013 · 1 comment
Closed

Put os::change_dir_locked somewhere else #7870

brson opened this issue Jul 18, 2013 · 1 comment

Comments

@brson
Copy link
Contributor

brson commented Jul 18, 2013

This is a test helper specifically for working around races when changing directories in test cases. As a public API it is very weird and deadlock-prone.

Not sure the best place for it. Perhaps std::unstable, though there's also a std::rt::test module for runtime test helpers.
brson added a commit to brson/rust that referenced this issue Jul 18, 2013
@brson
std: Move change_dir_locked to unstable. rust-lang#7870
2401c8e
@brson brson mentioned this issue Jul 18, 2013
Closed
brson added a commit to brson/rust that referenced this issue Jul 22, 2013
@brson
std: Move change_dir_locked to unstable. rust-lang#7870
6174f9a
bors added a commit that referenced this issue Jul 22, 2013
@bors
auto merge of #7883 : brson/rust/rm-std-net, r=graydon
73921f9 
This removes all the code from libextra that depends on libuv. After that it removes three runtime features that existed to support the global uv loop: weak tasks, runtime-global variables, and at_exit handlers.

The networking code doesn't have many users besides servo, so shouldn't have much fallout. The timer code though is useful and will probably break out-of-tree code until the new scheduler lands, but I expect that to be soon.

It also incidentally moves `os::change_dir_locked` to `std::unstable`. This is a function used by test cases to avoid cwd races and in my opinion shouldn't be public (#7870).

Closes #7251 and #7870
@catamorphism
Copy link
Contributor

change_dir_locked seems to be no longer. Closing.

flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 23, 2021
@bors
Auto merge of rust-lang#7980 - dswij:7870, r=xFrednet
d6c707d 
Fix FP on `if_then_some_else_none` when there is early return

closes rust-lang#7870

changelog: [`if_then_some_else_none`] now does not fire when there is early return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @catamorphism