Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for #![feature(const_io_structs)] #78812

Closed
3 tasks done
a1phyr opened this issue Nov 6, 2020 · 7 comments · Fixed by #124049
Closed
3 tasks done

Tracking Issue for #![feature(const_io_structs)] #78812

a1phyr opened this issue Nov 6, 2020 · 7 comments · Fixed by #124049
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@a1phyr
Copy link
Contributor

a1phyr commented Nov 6, 2020

This is a tracking issue for #![feature(const_io_structs)]

New const functions are:

  • io::Cursor::new
  • io::Cursor::get_ref
  • io::Cursor::position
  • io::empty
  • io::repeat
  • io::sink

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

@a1phyr a1phyr added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Nov 6, 2020
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 7, 2020
Make some std::io functions `const`

Tracking issue: rust-lang#78812

Make the following functions `const`:
- `io::Cursor::new`
- `io::Cursor::get_ref`
- `io::Cursor::position`
- `io::empty`
- `io::repeat`
- `io::sink`

r? `@dtolnay`
@LeSeulArtichaut LeSeulArtichaut added A-const-fn T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 7, 2020
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 7, 2020
Make some std::io functions `const`

Tracking issue: rust-lang#78812

Make the following functions `const`:
- `io::Cursor::new`
- `io::Cursor::get_ref`
- `io::Cursor::position`
- `io::empty`
- `io::repeat`
- `io::sink`

r? ``@dtolnay``
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 7, 2020
Make some std::io functions `const`

Tracking issue: rust-lang#78812

Make the following functions `const`:
- `io::Cursor::new`
- `io::Cursor::get_ref`
- `io::Cursor::position`
- `io::empty`
- `io::repeat`
- `io::sink`

r? ```@dtolnay```
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 7, 2020
Make some std::io functions `const`

Tracking issue: rust-lang#78812

Make the following functions `const`:
- `io::Cursor::new`
- `io::Cursor::get_ref`
- `io::Cursor::position`
- `io::empty`
- `io::repeat`
- `io::sink`

r? ````@dtolnay````
m-ou-se added a commit to m-ou-se/rust that referenced this issue Nov 8, 2020
Make some std::io functions `const`

Tracking issue: rust-lang#78812

Make the following functions `const`:
- `io::Cursor::new`
- `io::Cursor::get_ref`
- `io::Cursor::position`
- `io::empty`
- `io::repeat`
- `io::sink`

r? `````@dtolnay`````
@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Dec 16, 2020
@KodrAus KodrAus added the A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` label Jan 6, 2021
@jhpratt
Copy link
Member

jhpratt commented Apr 20, 2021

Are there any blockers for these? They appear to all have straightforward implementations that should work on stable.

CC @dtolnay who r+'d the original PR

@Stebalien
Copy link
Contributor

Hey, I'd love to have this if we can make it stable. This would make it possible to, e.g., create "global" spooled temporary files without lazy_static:

static BUFFER: Mutex<SpooledTempFile> = Mutex::new(tempfile::SpooledTempFile::new(1024 * 1024));

@rfcbot
Copy link

rfcbot commented Apr 5, 2024

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Apr 5, 2024
@rfcbot
Copy link

rfcbot commented Apr 6, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@oli-obk
Copy link
Contributor

oli-obk commented Apr 6, 2024

All of these lgtm from a @rust-lang/wg-const-eval perspective. they are just trivial accessors or constructor funcions

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 16, 2024
@rfcbot
Copy link

rfcbot commented Apr 16, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

RalfJung added a commit to RalfJung/rust that referenced this issue Apr 17, 2024
…ze, r=jhpratt

Stabilize `const_io_structs`

This PR stabilizes `const_io_structs`.

Tracking issue: rust-lang#78812.
Implementation PR: rust-lang#78811.

FCPs already completed in the tracking issue.

Closes rust-lang#78812.

`@rustbot` label: +T-libs-api

r? libs-api
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Apr 17, 2024
…ze, r=jhpratt

Stabilize `const_io_structs`

This PR stabilizes `const_io_structs`.

Tracking issue: rust-lang#78812.
Implementation PR: rust-lang#78811.

FCPs already completed in the tracking issue.

Closes rust-lang#78812.

``@rustbot`` label: +T-libs-api

r? libs-api
RalfJung added a commit to RalfJung/rust that referenced this issue Apr 17, 2024
…ze, r=jhpratt

Stabilize `const_io_structs`

This PR stabilizes `const_io_structs`.

Tracking issue: rust-lang#78812.
Implementation PR: rust-lang#78811.

FCPs already completed in the tracking issue.

Closes rust-lang#78812.

``@rustbot`` label: +T-libs-api

r? libs-api
@bors bors closed this as completed in 8f3fd93 Apr 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Apr 17, 2024
Rollup merge of rust-lang#124049 - slanterns:const_io_structs_stabilize, r=jhpratt

Stabilize `const_io_structs`

This PR stabilizes `const_io_structs`.

Tracking issue: rust-lang#78812.
Implementation PR: rust-lang#78811.

FCPs already completed in the tracking issue.

Closes rust-lang#78812.

```@rustbot``` label: +T-libs-api

r? libs-api
RalfJung pushed a commit to RalfJung/miri that referenced this issue Apr 17, 2024
…ratt

Stabilize `const_io_structs`

This PR stabilizes `const_io_structs`.

Tracking issue: rust-lang/rust#78812.
Implementation PR: rust-lang/rust#78811.

FCPs already completed in the tracking issue.

Closes rust-lang/rust#78812.

```@rustbot``` label: +T-libs-api

r? libs-api
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label May 3, 2024
@RalfJung RalfJung added the A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants