Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On docs search results page, make down/up arrows select search results by auto focusing search field #78824

Closed
Boscop opened this issue Nov 6, 2020 · 2 comments
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Boscop
Copy link

Boscop commented Nov 6, 2020

Before, when you opened a rust doc page by a url containing a search query, after the page loaded, you could navigate with down/up arrows through the matched symbols.
Now it doesn't work anymore, you have to use the mouse to click!
E.g. an url like https://doc.rust-lang.org/nightly/std/?search=scan or https://docs.rs/imgui/0.4.0/imgui/struct.Ui.html?search=set

Maybe the fix is as simple as putting the autofocus attribute on the search input, so that the first down arrow press selects the first search result.

CC @jyn514
@rustbot modify labels: +T-rustdoc

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 6, 2020
@jyn514 jyn514 added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label Nov 6, 2020
@camelid camelid self-assigned this Nov 9, 2020
@camelid
Copy link
Member

camelid commented Dec 8, 2020

I couldn't get autofocus to work, so I'm unassigning myself.

@GuillaumeGomez
Copy link
Member

It was rejected in #77333. Closing it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants