Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc search is broken on mobile #79526

Closed
jyn514 opened this issue Nov 29, 2020 · 0 comments · Fixed by #80412
Closed

Rustdoc search is broken on mobile #79526

jyn514 opened this issue Nov 29, 2020 · 0 comments · Fixed by #80412
Assignees
@GuillaumeGomez
Labels
A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Nov 29, 2020

Steps to reproduce (@pickfire used firefox on mobile):

  1. go to search page
  2. type something to search
  3. blue the search (keyboard lowers)
  4. you cannot click on search bar anymore

Oh, I just found out that it works except the click position is way out, you need to touch the corner of the screen rather than the center of the box itself.

Originally posted by @pickfire in #77333 (comment)
@jyn514 jyn514 added A-rustdoc-search Area: Rustdoc's search feature C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Nov 29, 2020
@GuillaumeGomez GuillaumeGomez self-assigned this Dec 27, 2020
@GuillaumeGomez GuillaumeGomez mentioned this issue Dec 27, 2020
Merged
@bors bors closed this as completed in fde6927 Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-search Area: Rustdoc's search feature A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix search section position on small devices GuillaumeGomez/rust
2 participants
@GuillaumeGomez @jyn514