Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document attributes related to linking: link, link_args, no_link, ...? #7960

Closed
3 of 4 tasks
pnkfelix opened this issue Jul 22, 2013 · 7 comments
Closed
3 of 4 tasks
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@pnkfelix
Copy link
Member

Sub-bug of #6444

  • link (Introduced by d4c40b5)
  • link_args (Introduced by d4c40b5)
  • link_name (already in rust.md; see commit 772028a)
  • nolink
@huonw
Copy link
Member

huonw commented Oct 18, 2013

Triage: no progress.

@alexcrichton
Copy link
Member

cc #9910

@flaper87
Copy link
Contributor

visiting for triage. Updated the issue description and the parent issue with the latest commits that improved the documentation. nolink seems to still be missing.

@alexcrichton
Copy link
Member

nolink is no longer an attribute, so it looks like this is done!

@flaper87
Copy link
Contributor

@alexcrichton but we still have it in some modules like libc and os. Can those be removed then?

@alexcrichton
Copy link
Member

Yes, they should be removed. I didn't realize we still had some lying around. If it's an allowed attribute in the lint passes that should also be removed.

@flaper87
Copy link
Contributor

@alexcrichton ok, I'll get rid of them then. thanks

flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 23, 2021
…logiq

fix suggestion in option_map_or_none

fix: rust-lang#7960
changelog: change suggestion in the lint rule `option_map_or_none`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

4 participants