Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for IntoInnerError::into_parts etc. (io_into_inner_error_parts) #79704

Closed
3 tasks done
ijackson opened this issue Dec 4, 2020 · 4 comments · Fixed by #87175
Closed
3 tasks done

Tracking Issue for IntoInnerError::into_parts etc. (io_into_inner_error_parts) #79704

ijackson opened this issue Dec 4, 2020 · 4 comments · Fixed by #87175
Assignees
Labels
A-error-handling Area: Error handling A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ijackson
Copy link
Contributor

ijackson commented Dec 4, 2020

This is a tracking issue for std::io::IntoInnerError::into_parts and ::into_error.
The feature gate for the issue is #![feature(io_into_inner_error_parts)].

Public API

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

These new methods are being introduced as an unstable feature to give time to validate their names, types, and documentation, before stabilisation.

Implementation history

Implementation (with docs) is in #79673, currently in review/rework.

@ijackson ijackson added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Dec 4, 2020
@m-ou-se m-ou-se added A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Dec 4, 2020
@KodrAus KodrAus added the Libs-Tracked Libs issues that are tracked on the team's project board. label Dec 16, 2020
@KodrAus KodrAus added the A-error-handling Area: Error handling label Jan 6, 2021
@dtolnay
Copy link
Member

dtolnay commented May 23, 2021

@rust-lang/libs
@rfcbot fcp merge

Check out @ijackson's recap of this API in #84770 (comment).

@rfcbot
Copy link

rfcbot commented May 23, 2021

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 23, 2021
@rfcbot
Copy link

rfcbot commented Jul 5, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 5, 2021
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jul 15, 2021
@rfcbot
Copy link

rfcbot commented Jul 15, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@bors bors closed this as completed in f335bca Jul 23, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Aug 5, 2021
@inquisitivecrystal inquisitivecrystal self-assigned this Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-error-handling Area: Error handling A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Tracked Libs issues that are tracked on the team's project board. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants