Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#79286 #79709

Closed
rust-highfive opened this issue Dec 4, 2020 · 2 comments · Fixed by #79724
Closed

miri no longer builds after rust-lang/rust#79286 #79709

rust-highfive opened this issue Dec 4, 2020 · 2 comments · Fixed by #79724
Assignees
@m-ou-se
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #79286, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @TimDiekmann, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Dec 4, 2020
@camelid camelid self-assigned this Dec 4, 2020
@m-ou-se m-ou-se mentioned this issue Dec 4, 2020
Merged
@m-ou-se
Copy link
Member

m-ou-se commented Dec 4, 2020

@camelid Oops, race condition! Noticed you self-assigned this right as I sent a PR for this. ^^

@camelid camelid assigned m-ou-se and unassigned eddyb, RalfJung, oli-obk and camelid Dec 4, 2020
@TimDiekmann
Copy link
Member

You can assign me if needed.

bors added a commit to rust-lang/miri that referenced this issue Dec 5, 2020
@bors
Auto merge of #1639 - m-ou-se:allocator, r=RalfJung
e54c5db 
Update to new core::alloc::Allocator interface

This fixes the allocator test for the changes made to the allocator trait in `core` in rust-lang/rust#79286

See rust-lang/rust#79709
@RalfJung RalfJung mentioned this issue Dec 5, 2020
Merged
@bors bors closed this as completed in 551a2c6 Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-ou-se m-ou-se

Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update Miri RalfJung/rust
7 participants
@eddyb @RalfJung @oli-obk @m-ou-se @rust-highfive @TimDiekmann @camelid