Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Z dump-dep-graph no longer prints def paths since PR #74967 #79723

Open
Aaron1011 opened this issue Dec 5, 2020 · 0 comments
Open

-Z dump-dep-graph no longer prints def paths since PR #74967 #79723

Aaron1011 opened this issue Dec 5, 2020 · 0 comments
Assignees
@Aaron1011
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Aaron1011
Copy link
Member

Aaron1011 commented Dec 5, 2020 •
edited
Loading

The changes in PR #74967 ended up breaking the way that we debug-print DepNodes with -Z dump-dep-graph.
The simplest way to fix this might be to just fall back to the old approach (build a table of all DefPathHashes across all crates) when we need to debug-print for -Z dump-dep-graph.
@Aaron1011 Aaron1011 added the C-bug Category: This is a bug. label Dec 5, 2020
@Aaron1011 Aaron1011 changed the title -Z dump-graph now longer prints def paths since PR #74967 -Z dump-graph no longer prints def paths since PR #74967 Dec 5, 2020
@Aaron1011 Aaron1011 self-assigned this Dec 5, 2020
@Aaron1011 Aaron1011 changed the title -Z dump-graph no longer prints def paths since PR #74967 -Z dump-dep-graph no longer prints def paths since PR #74967 Jan 2, 2021
Aaron1011 added a commit to Aaron1011/rust that referenced this issue Jan 2, 2021
@Aaron1011
Load all DefPathHash -> DefId mappings before dumping dep graph
03e5741 
Fixes rust-lang#79723
@Aaron1011 Aaron1011 mentioned this issue Jan 2, 2021
Closed
@jieyouxu jieyouxu added A-resolve Area: Name/path resolution done by `rustc_resolve` specifically T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage-legacy labels Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aaron1011 Aaron1011

Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load all DefPathHash -> DefId mappings before dumping dep graph Aaron1011/rust
3 participants
@Aaron1011 @ChrisDenton @jieyouxu