-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Labels
A-mir-optArea: MIR optimizationsArea: MIR optimizationsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Description
in #77413 it was noted that MIR dumps in our test suite somtimes differ between little and big endian, making our test suite fail on big endian. This is just about MIR pretty printing.
All that needs to be done is to pull out
rust/compiler/rustc_mir/src/util/pretty.rs
Lines 432 to 436 in 5ded394
match ty.kind() { | |
ty::Int(_) | ty::Uint(_) | ty::Bool | ty::Char | ty::Float(_) => {} | |
// Unit type | |
ty::Tuple(tys) if tys.is_empty() => {} | |
ty::FnDef(..) => {} |
true
if the verbose printing should be used and then make it recurse on ty::Tuple
and ty::Array
elements.
You can then run rerun tests separately for 64bit and 32bit (the latter via e.g. --target i686-unknown-linux-gnu
)
Metadata
Metadata
Assignees
Labels
A-mir-optArea: MIR optimizationsArea: MIR optimizationsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.