Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc search results heading illegible colour scheme #79961

Closed
ijackson opened this issue Dec 12, 2020 · 5 comments · Fixed by #79973
Closed

rustdoc search results heading illegible colour scheme #79961

ijackson opened this issue Dec 12, 2020 · 5 comments · Fixed by #79973
Assignees
@camelid
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) P-medium Medium priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone
1.50.0

Comments

@ijackson
Copy link
Contributor

ijackson commented Dec 12, 2020 •
edited
Loading

The rustdoc search results page has three tabs of results: "In Names", "In Parameters", and "In Return Types".

In my browser with the default theme, the selected tab heading is drawn in black on black.

screenshot
@ijackson
Copy link
Contributor Author

@rustbot modify labels +T-rustdoc +A-rustdoc-ui +regression-from-stable-to-nightly

@rustbot rustbot added A-rustdoc-ui Area: Rustdoc UI (generated HTML) regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Dec 12, 2020
@Mark-Simulacrum Mark-Simulacrum added this to the 1.50.0 milestone Dec 12, 2020
@camelid
Copy link
Member

camelid commented Dec 12, 2020

Yes, I've been having this too. You beat me to reporting this bug and #79960; thank you for making good reports!

@jyn514 jyn514 added the E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc label Dec 12, 2020
@camelid
Copy link
Member

camelid commented Dec 12, 2020

I did some bisection and it seems the most likely cause is #79896.

@camelid
Copy link
Member

camelid commented Dec 12, 2020

Ah, I think I know what the issue is.

@camelid camelid self-assigned this Dec 12, 2020
@camelid camelid mentioned this issue Dec 12, 2020
Merged
@camelid camelid added P-medium Medium priority and removed E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Dec 12, 2020
@camelid
Copy link
Member

camelid commented Dec 12, 2020

Labeled as P-medium since I made the fix and it's in the bors queue.

@bors bors closed this as completed in 5115bbf Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camelid camelid

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) P-medium Medium priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging a pull request may close this issue.

rustdoc light theme: Fix CSS for selected buttons camelid/rust
5 participants
@ijackson @Mark-Simulacrum @jyn514 @camelid @rustbot