Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LangString::all_false() to default() #80015

Closed
jyn514 opened this issue Dec 13, 2020 · 1 comment · Fixed by #80206
Closed

Rename LangString::all_false() to default() #80015

jyn514 opened this issue Dec 13, 2020 · 1 comment · Fixed by #80206
Assignees
@poliorcetics
Labels
A-markdown-parsing Area: Markdown parsing for doc-comments C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 13, 2020 •
edited by rustbot
Loading

LangString::all_false is not actually all_false - rust will return true. It would be nice to rename it to default() at some point (and maybe add impl Default for LangString while we're at it).

cc @poliorcetics

Originally posted by @jyn514 in #80013 (comment)
@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-markdown-parsing Area: Markdown parsing for doc-comments and removed A-testsuite Area: The testsuite used to check the correctness of rustc labels Dec 13, 2020
@poliorcetics
Copy link
Contributor

@rustbot claim

I'll either get to it before next week is over or when #79454 is merged, whichever comes first

@poliorcetics poliorcetics mentioned this issue Dec 19, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 20, 2020
@Dylan-DPC
Rollup merge of rust-lang#80206 - poliorcetics:rustdoc-default-langst…
060480b 
…ring, r=GuillaumeGomez,jyn514

impl Default for LangString, replacing all_false by default

Fix rust-lang#80015

`@rustbot` label C-cleanup  T-rustdoc  A-markdown-parsing
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 20, 2020
@Dylan-DPC
Rollup merge of rust-lang#80206 - poliorcetics:rustdoc-default-langst…
6af5e7a 
…ring, r=GuillaumeGomez,jyn514

impl Default for LangString, replacing all_false by default

Fix rust-lang#80015

``@rustbot`` label C-cleanup  T-rustdoc  A-markdown-parsing
@bors bors closed this as completed in 463ce40 Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poliorcetics poliorcetics

Labels
A-markdown-parsing Area: Markdown parsing for doc-comments C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

impl Default for LangString, replacing all_false by default poliorcetics/rust
2 participants
@poliorcetics @jyn514