Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing source links in std::iter::Iterator docs #80502

Closed
qrilka opened this issue Dec 30, 2020 · 5 comments · Fixed by #82040
Closed

Missing source links in std::iter::Iterator docs #80502

qrilka opened this issue Dec 30, 2020 · 5 comments · Fixed by #82040
Labels
C-bug Category: This is a bug. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@qrilka
Copy link

qrilka commented Dec 30, 2020

I was looking into https://doc.rust-lang.org/std/iter/trait.Iterator.html trying to find source code for the zip method

I expected to see "src" with a link to the function source code.

Instead, there appear to be no such link and other methods (even next!) of this trait also lack source code links.

@qrilka qrilka added the C-bug Category: This is a bug. label Dec 30, 2020
@ThePuzzlemaker
Copy link
Contributor

ThePuzzlemaker commented Jan 1, 2021

This appears to have been fixed in nightly. (see https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html, the nightly docs for std::iter::Iterator).

@qrilka
Copy link
Author

qrilka commented Jan 1, 2021

Then probably this could be closed, one thing though is to find the reason that happened and have some measures against it reintroduced again.

@GuillaumeGomez
Copy link
Member

It'd require to add a test to prevent the regression (in src/test/rustdoc). I'll mark the issue as E-medium because it might require to extend those tests to be able to check directly on std docs.

@GuillaumeGomez GuillaumeGomez added E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 3, 2021
@Stupremee
Copy link
Member

Is there a reason this issue is still open? Since this seems to be fixed already

@GuillaumeGomez
Copy link
Member

We still need to add a test to ensure that the [src] link is present, I'll do that so we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants