Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.py does not warn if test filters for file that does not exist #80621

Closed
bugadani opened this issue Jan 2, 2021 · 0 comments · Fixed by #80627
Closed

x.py does not warn if test filters for file that does not exist #80621

bugadani opened this issue Jan 2, 2021 · 0 comments · Fixed by #80627
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@bugadani
Copy link
Contributor

bugadani commented Jan 2, 2021 •
edited
Loading

I tried to run a specific ui test using ./x.py test src/test/ui/..., but mistyped the test's file name. This resulted in the file name silently being ignored and x.py started to execute all available tests instead.
@bugadani bugadani added the C-bug Category: This is a bug. label Jan 2, 2021
@jyn514 jyn514 added A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc labels Jan 2, 2021
@bugadani bugadani mentioned this issue Jan 2, 2021
Merged
@bors bors closed this as completed in 1c6593c Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Builder: Warn if test file does not exist bugadani/rust
2 participants
@bugadani @jyn514