Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move local_data_priv somewhere else #8113

Closed
brson opened this issue Jul 29, 2013 · 4 comments
Closed

Move local_data_priv somewhere else #8113

brson opened this issue Jul 29, 2013 · 4 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jul 29, 2013

At some point we moved the public interface to local data to std::local_data (which I think was the right decision), but the private portion lives in task::local_data_priv. This is a peculiar factoring of this subsystem.

@lilyball
Copy link
Contributor

lilyball commented Aug 1, 2013

Would it make sense to move this to std::local_data::priv?

@alexcrichton
Copy link
Member

A question I'd have is if there's a reason it shouldn't just be in std::local_data to begin with? All of the functions there are just thin wrappers around the std::local_data_priv functions right now.

@brson
Copy link
Contributor Author

brson commented Aug 5, 2013

I think my preference would be to put it in local_data directly and make the task::spawn module not rely on the private interface. The reason it was separated to begin with was that task::spawn wanted access to the private implementation and making them two different mods was the only way to keep the _priv parts actually private.

@alexcrichton
Copy link
Member

@brson, do you have an idea for how much longer the old scheduler is going to stick around? This looks like it'll be easier to move once this code path doesn't have to explicitly ask for a lookup in the old scheduler (as opposed to the new).

bors added a commit that referenced this issue Aug 28, 2013
This moves all local_data stuff into the `local_data` module and only that
module alone. It also removes a fair amount of "super-unsafe" code in favor of
just vanilla code generated by the compiler at the same time.

Closes #8113
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 13, 2022
…logiq

Better detect when a field can be moved from in `while_let_on_iterator`

fixes rust-lang#8113

changelog: Better detect when a field can be moved from in `while_let_on_iterator`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants