Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the expr_method_call function entirely in favour of ufc #81295

Closed
oli-obk opened this issue Jan 23, 2021 · 1 comment
Closed

Deprecate the expr_method_call function entirely in favour of ufc #81295

oli-obk opened this issue Jan 23, 2021 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Jan 23, 2021

Using method calls in built in derives keeps causing problems due to different imports in the surrounding scope.

Maybe we should just remove the expr_method_call function entirely (or perma-deprecate it so ppl searching for it get an explanation of why they should use ufcs)

Originally posted by @oli-obk in #81294 (comment)
@jonas-schievink jonas-schievink added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 23, 2021
@Skgland Skgland mentioned this issue Jan 26, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 10, 2021
@bors
Auto merge of rust-lang#81411 - Skgland:deprecate_expr_method_call, r…
ca98712 
…=varkor

Remove usages of `expr_method_call` in derive(Ord,PartialOrd,RustcEncode,RustcDecode)

Preparing for deprecation of `expr_method_call`  (rust-lang#81295), by removing the remaining usages not covered by (rust-lang#81294).

I am not sure about the changes to `derive(RustcEncode,RustcDecode)`
@Skgland
Copy link
Contributor

Skgland commented May 22, 2021

expr_method_call has been removed in 441dc36

@oli-obk oli-obk closed this as completed May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oli-obk @jonas-schievink @Skgland