Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unstable_name_collisions lint gives wrong message and suggestion for associated constants. #81663

Closed
m-ou-se opened this issue Feb 2, 2021 · 0 comments · Fixed by #81713
Closed

unstable_name_collisions lint gives wrong message and suggestion for associated constants. #81663

m-ou-se opened this issue Feb 2, 2021 · 0 comments · Fixed by #81713
Assignees
@estebank
Labels
A-diagnostics Area: Messages for errors, warnings, and lints D-confusing Diagnostics: Confusing error or lint that should be reworked. D-incorrect Diagnostics: A diagnostic that is giving misleading or incorrect information. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@m-ou-se
Copy link
Member

m-ou-se commented Feb 2, 2021

The unstable_name_collisions lint calls an associated constant a 'method', and suggests Trait::CONST(...) instead of <... as Trait>::CONST.

Example:

warning: a method with this name may be added to the standard library in the future
    --> src/atof/algorithm/math.rs:1909:34
     |
1909 | const ALGORITHM_D_B: Wide = 1 << Limb::BITS;
     |                                  ^^^^^^^^^^
     |
     = note: `#[warn(unstable_name_collisions)]` on by default
     = warning: once this method is added to the standard library, the ambiguity may cause an error or change in behavior!
     = note: for more information, see issue #48919 <https://github.com/rust-lang/rust/issues/48919>
     = help: call with fully qualified syntax `util::num::Integer::BITS(...)` to keep using the current method
@m-ou-se m-ou-se added A-diagnostics Area: Messages for errors, warnings, and lints D-confusing Diagnostics: Confusing error or lint that should be reworked. D-incorrect Diagnostics: A diagnostic that is giving misleading or incorrect information. labels Feb 2, 2021
@estebank estebank added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 2, 2021
@estebank estebank self-assigned this Feb 2, 2021
@m-ou-se m-ou-se changed the title unstable_name_collisions lint gives wrong message suggestion for associated constants. unstable_name_collisions lint gives wrong message and suggestion for associated constants. Feb 2, 2021
@estebank estebank mentioned this issue Feb 3, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 25, 2021
@Dylan-DPC
Rollup merge of rust-lang#81713 - estebank:unstable-assoc-item-lint, …
c562913 
…r=oli-obk

Account for associated consts in the "unstable assoc item name colission" lint

Fix rust-lang#81663.
@bors bors closed this as completed in e655941 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estebank estebank

Labels
A-diagnostics Area: Messages for errors, warnings, and lints D-confusing Diagnostics: Confusing error or lint that should be reworked. D-incorrect Diagnostics: A diagnostic that is giving misleading or incorrect information. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Account for associated consts in the "unstable assoc item name colission" lint estebank/rust
2 participants
@m-ou-se @estebank