-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename macro_rules! to macro! #8224
Comments
What about |
@glehel I think we don't want people to think that our macros work like C macros, so we might not wanna mirror that name. |
To implement this change, is it possible to just add the macro syntax extension twice, once under the new name, and then migrate all instances after a snapshot? |
@blake2-ppc it should be possible to do that, basically just register another syntax extension that goes to the same code. Also, I'm nominating this for backwards compatible. |
I believe that @paulstansifer and/or @jbclements specifically favored the |
Though perhaps we could find a middle ground and rename |
Have we thought about what we will name the procedural-macro-generating construct, when that is implemented? If we have multiple ways of defining macros, it seems like it would be weird for only one of them to be called |
I have no dog in this fight; I'm not a strong defender of macro_rules!. |
@paulstansifer What is this procedural-macro-generating construct you speak of? |
@bstrie It doesn't exist, but the prevailing mood (as I understand it) is that it should exist, eventually. |
Leaving this up for debate. Macros are not in scope for 1.0, so de-milestoning |
I prefer the name macro!() |
Triage: as @catamorphism says, no change, but not an 1.0 concern due to feature-gating. I do agree with @paulstansifer though: calling this |
This issue has been moved to the RFCs repo: rust-lang/rfcs#293 |
… r=llogiq Fix `type_repetition_in_bounds` fixes rust-lang#7360 fixes rust-lang#8162 fixes rust-lang#8056 changelog: Check for full equality in `type_repetition_in_bounds` rather than just equal hashes
Use a shorter and easier to understand name for this oft-used syntax extension.
The text was updated successfully, but these errors were encountered: