-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sporadic test failure for srcloc assembly test (non-optimized). #82886
Comments
This doesn't seem to happen with |
AFAIK, the channel used for emitting diagnostic from codegen threads is not guaranteed to be fully drained when compilation session is aborted. |
Fixes to inline assmebly tests * Join test thread to make assertion effective in sym.rs test case * Use a single codegen unit to reduce non-determinism in srcloc.rs test rust-lang#82886
Fixes to inline assmebly tests * Join test thread to make assertion effective in sym.rs test case * Use a single codegen unit to reduce non-determinism in srcloc.rs test rust-lang#82886
Fixes to inline assmebly tests * Join test thread to make assertion effective in sym.rs test case * Use a single codegen unit to reduce non-determinism in srcloc.rs test rust-lang#82886
@Amanieu I left this open in the case there is an interest in fixing the underlying cause, if not feel free to close. |
The srcloc.rs test has seen a couple sporadic failures on CI with the
x86_64-gnu-nopt
job.The error is that it is not always emitting all 23 errors. Sometimes I see it report anywhere from 3 to 15 errors.
I'm able to reproduce locally with
rust.optimize-tests = false
, and running in a loop. The failure rate isn't high, but I can repro within a few seconds.cc @Amanieu
The text was updated successfully, but these errors were encountered: