-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Issue for RFC 3052: make the authors field optional #83227
Comments
Do you need help with this issue? I am very interested in implementing it. |
I'm also |
I will finish the rest of the task. @rustbot claim |
Thanks for the interest in implementing this ❤️ @hi-rustin to avoid duplicating work, note that there is a PR to stop displaying the field in the crates.io UI open already (rust-lang/crates.io#3132) since before this tracking issue was open. Added that PR and lf-'s one to the issue text. |
Got it. Thanks! |
start accepting crates without authorship information See rust-lang/rust#83227
RFC 3052: Stop including authors field in manifests made by cargo new See rust-lang/rust#83227 ~~This is definitely a draft as there are a couple of tests I'm still working on fixing.~~ One question I ran into while digging through these test failures is that there is a Cargo config option for author name, `cargo-new.name`. Should we keep supporting that? I feel like perhaps we should as the user has specified explicit intent that they want their name in the authors of a manifest as generated by `cargo new`, but it seems weird to support *just* that case. There is likewise an environment variable `CARGO_NAME` that signals similar intent. Should we completely drop the feature of putting in author names, and require people to manually put them in if they wish, or allow these limited cases where the user is specifically instructing *cargo* to do it?
@pietroalbini I think this already done. See also: rust-lang/crates.io#3132 (comment) |
What other documents need to be updated? |
@pietroalbini Could you please take a look? |
I just came across this. How does this change the |
Hi! This does not change CARGO_PKG_AUTHORS. All the current changes do is hide the authors field in various websites' UI and make it much harder to accidentally include it in a package as cargo-new does not introduce it. If you handle CARGO_PKG_AUTHORS being empty already (it was allowed to be before these changes, you just couldn't upload such crates to crates.io), you don't have to change anything. |
Sorry for taking a while to respond!
The two other actions needed on the crates.io side are:
Removed that point, it was a leftover from the tracking issue template. |
Got it. I will working on these. |
|
Whelp, not sure how that happened, fixed it! |
Return the empty list for authors API Part of rust-lang/rust#83227 (comment) Stop returning authorship information from the API, changing the endpoint to always return an empty list.
The author's field is now optional per rust-lang/rust#83227 For sake of clarity, remove it across Hubris
The author's field is now optional per rust-lang/rust#83227 For sake of clarity, remove it across Hubris
It has been effectively soft-deprecated (<rust-lang/rust#83227>).
This is a tracking issue for the RFC "Make the authors field optional" (rust-lang/rfcs#3052).
About tracking issues
Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Steps
cargo new
/cargo init
and in templatesImplementation history
The text was updated successfully, but these errors were encountered: