Some run-make-fulldeps don't fail if -include fails

[jyn514]

I tried this code:

renamed:    run-make-fulldeps/exit-code/Makefile -> run-make/exit-code/Makefile
renamed:    run-make-fulldeps/exit-code/compile-error.rs -> run-make/exit-code/compile-error.rs
renamed:    run-make-fulldeps/exit-code/lint-failure.rs -> run-make/exit-code/lint-failure.rs
renamed:    run-make-fulldeps/exit-code/success.rs -> run-make/exit-code/success.rs

I expected to see this happen: The test fails, because the Makefile includes ../tools.mk which doesn't exist - it should include ../../run-make-fulldeps/tools.mk instead.

Instead, this happened: The test passes.

I can change it to a hard error by changing -include to include, but it seems bad to have a test that passes even if the commands it's running don't exist 😟

Meta

This is based off of a5029ac.

[jyn514]

Ok it looks like make defaults to the environment variable if it's not set? So because x.py is setting RUSTC and RUSTDOC for the bootstrap shim, they get set to reasonable values:

$ cat Makefile
all:
    echo $(RUSTC) $(RUSTDOC)
$ x.py test src/test/run-make/exit-code
echo /home/joshua/rustc3/build/x86_64-unknown-linux-gnu/stage1/bin/rustc /home/joshua/rustc3/build/x86_64-unknown-linux-gnu/stage1/bin/rustdoc

Maybe this doesn't need changes? I'm not sure how important it is that RUSTC and RUSTDOC get set to their new values:

rust/src/test/run-make-fulldeps/tools.mk

Lines 11 to 12 in 4fa76a4

	RUSTC := $(BARE_RUSTC) --out-dir $(TMPDIR) -L $(TMPDIR) $(RUSTFLAGS)
	RUSTDOC := $(BARE_RUSTDOC) -L $(TARGET_RPATH_DIR)

If it is important, I think the fix is as simple as changing -include to include everywhere.

[jyn514]

Looks like TMPDIR is also set: /home/joshua/rustc3/build/x86_64-unknown-linux-gnu/test/run-make/rustdoc-map-file/rustdoc-map-file