Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc links to type aliases that don't exist in search results #83991

Closed
RalfJung opened this issue Apr 8, 2021 · 3 comments · Fixed by #96887
Closed

rustdoc links to type aliases that don't exist in search results #83991

RalfJung opened this issue Apr 8, 2021 · 3 comments · Fixed by #96887
Labels
A-rustdoc-search Area: Rustdoc's search feature T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Apr 8, 2021

There are bad (404) links in search results with nightly rustdoc. E.g. go to https://doc.rust-lang.org/nightly/std/?search=as_raw_fd and then click the std::RawFd::as_raw_fd result. This leads to https://doc.rust-lang.org/nightly/std/type.RawFd.html#method.as_raw_fd which does not exist.

Cc @rust-lang/rustdoc
@RalfJung
Copy link
Member Author

RalfJung commented Apr 8, 2021

Actually, this issue seems to exist even on stable -- somehow it went unnoticed for quite a while, it seems.

@GuillaumeGomez GuillaumeGomez added A-rustdoc-search Area: Rustdoc's search feature T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 8, 2021
@GuillaumeGomez
Copy link
Member

I think it's because we are badly handling a reexport/type alias.

@jyn514 jyn514 changed the title nightly rustdoc: bad links in search results rustdoc links to type aliases that don't exist in search results Apr 8, 2021
@jyn514
Copy link
Member

jyn514 commented Apr 8, 2021

I think this is a duplicate of #78724.

@notriddle notriddle mentioned this issue May 10, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 10, 2022
@matthiaskrgr
Rollup merge of rust-lang#96887 - notriddle:notriddle/as-raw-fd, r=jsha
7cdb374 
rustdoc: correct path to type alias methods

Fixes rust-lang#83991
@bors bors closed this as completed in ed9faee May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-search Area: Rustdoc's search feature T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: correct path to type alias methods notriddle/rust
4 participants
@RalfJung @Manishearth @GuillaumeGomez @jyn514