Skip to content

miri no longer builds after rust-lang/rust#83948 #84202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rust-highfive opened this issue Apr 14, 2021 · 6 comments · Fixed by #84215
Closed

miri no longer builds after rust-lang/rust#83948 #84202

rust-highfive opened this issue Apr 14, 2021 · 6 comments · Fixed by #84215
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #83948, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @ABouttefeux, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Apr 14, 2021
@ABouttefeux
Copy link
Contributor

yes I can work on that :)

@RalfJung
Copy link
Member

@ABouttefeux that would be great. :) However, there's some amount of urgency here as these Miri failures tend to accumulate.

@ABouttefeux
Copy link
Contributor

I am not particularly fast. So maybe someone else should work on that if they want to.

@ghost
Copy link

ghost commented Apr 15, 2021

error: tests/compile-fail/null_pointer_deref.rs:2: unexpected error: '2:27: 2:44: dereferencing a null pointer [deref_nullptr]'

It seems just lacking some #[allow]s.

@RalfJung
Copy link
Member

@ABouttefeux that's okay! Sadly, these Miri breakages are not good opportunities for first-time Miri contribution. Thanks anyway. :) I'll take care of it.

@ABouttefeux
Copy link
Contributor

@RalfJung as pointed by @hyd-dev it seems simple enough I can do it now

bors added a commit to rust-lang/miri that referenced this issue Apr 15, 2021
Fix failing test after merge of PR rust#83948

Cc rust-lang/rust#84202
@RalfJung RalfJung mentioned this issue Apr 15, 2021
@bors bors closed this as completed in 8aa1181 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants