Skip to content

Building using brew on OSX generates 12,192 "not allowed" .gitattributes messages #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjheath opened this issue Aug 10, 2013 · 4 comments

Comments

@cjheath
Copy link

cjheath commented Aug 10, 2013

The following two-line message appears 12,192 times when building rust from source using "brew install --HEAD rust":

[attr]rust text eol=lf whitespace=tab-in-indent,trailing-space,tabwidth=4
not allowed: /private/tmp/rust-9Vuk/.gitattributes:1

It seems to cause no harm, other than obscuring any genuine messages.
"uname -a" says:
Darwin helios 12.4.0 Darwin Kernel Version 12.4.0: Wed May 1 17:57:12 PDT 2013; root:xnu-2050.24.15~1/RELEASE_X86_64 x86_64
git --version says:
git version 1.7.10.2 (Apple Git-33)

brew is up-to-date: "brew --version" says:
0.9.4

@sanxiyn
Copy link
Member

sanxiyn commented Dec 16, 2013

Triage. Does this still happen? I don't have a Mac OS X machine.

@steveklabnik
Copy link
Member

I don't have an OSX machine either. Given the lack of commentary, I'd be willing to be it doesn't happen, but it'd be nice to know.

@reem
Copy link
Contributor

reem commented Aug 14, 2014

I've built rust with brew recently and this no longer happens.

@alexcrichton
Copy link
Member

Ok, feel free to reopen if this still happens!

flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 21, 2022
Add `await_holding_invalid_type` lint

changelog: [`await_holding_invalid_type`]

This lint allows users to create a denylist of types which are not allowed to be
held across await points. This is essentially a re-implementation of the
language-level [`must_not_suspend`
lint](rust-lang#83310). That lint has a lot of
work still to be done before it will reach Rust stable, and in the meantime
there are a lot of types which can trip up developers if they are used
improperly.

I originally implemented this specifically for `tracing::span::Entered`, until I discovered rust-lang#8434 and read the commentary on that PR. Given this implementation is fully user configurable, doesn't tie clippy to any one particular crate, and introduces no additional dependencies, it seems more appropriate.
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 17, 2024
cfg Attribute Stripping for Proc Macro Expansion

This will attempt to process cfg attributes and cfg_attr attributes for proc macro expansion.
![image](https://github.com/rust-lang/rust-analyzer/assets/11785959/b85ef203-14a5-44c9-9b67-59a65a5f2d96)

Closes rust-lang#8434 , rust-lang#11657, and rust-lang#13904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants