Skip to content

Update compiler error message for E0761 #84828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zerotask opened this issue May 2, 2021 · 1 comment · Fixed by #84854
Closed

Update compiler error message for E0761 #84828

Zerotask opened this issue May 2, 2021 · 1 comment · Fixed by #84854
Assignees
@0xPoe
Labels
A-diagnostics Area: Messages for errors, warnings, and lints D-terse Diagnostics: An error or lint that doesn't give enough information about the problem at hand. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Zerotask
Copy link

Zerotask commented May 2, 2021 •
edited by rustbot
Loading

The compiler error message for E0761
image

should include the src folder and it should use double quotes, similar to the help message of compiler error E0583:

image

Before

error[E0761]: file for module `user` found at both user.rs and user\mod.rs

After

error[E0761]: file for module `user` found at both "src\user.rs" and "src\user\mod.rs"
@jyn514 jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints D-terse Diagnostics: An error or lint that doesn't give enough information about the problem at hand. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 2, 2021
@0xPoe
Copy link
Member

0xPoe commented May 3, 2021

@rustbot claim

@0xPoe 0xPoe mentioned this issue May 3, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 3, 2021
@GuillaumeGomez
Rollup merge of rust-lang#84854 - hi-rustin:rustin-patch-E0761, r=varkor
5c91a4d 
use double quotes and full path for E0761

close rust-lang#84828
@bors bors closed this as completed in 3777221 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xPoe 0xPoe

Labels
A-diagnostics Area: Messages for errors, warnings, and lints D-terse Diagnostics: An error or lint that doesn't give enough information about the problem at hand. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use double quotes and full path for E0761 0xPoe/rust
3 participants
@Zerotask @jyn514 @0xPoe