Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the error messages to match the pattern "expected foo, found bar" #8492

Closed
kud1ing opened this issue Aug 13, 2013 · 0 comments · Fixed by #16699
Closed

Adjust the error messages to match the pattern "expected foo, found bar" #8492

kud1ing opened this issue Aug 13, 2013 · 0 comments · Fixed by #16699
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@kud1ing
Copy link

kud1ing commented Aug 13, 2013

... as suggested by the style guide.

I tried to do this myself in PR #8413 and #8314. But when the PRs got merged, several days had passed and i got lost in rebase land.
@treeman treeman mentioned this issue Aug 23, 2014
Merged
bors added a commit that referenced this issue Aug 25, 2014
@bors
auto merge of #16699 : treeman/rust/issue-8492, r=alexcrichton
0b3e43d 
Closes #8492.

I did not find this suggestion in the [guidelines][] but it's mentioned in the [old style guide][].

[guidelines]: https://github.com/rust-lang/rust-guidelines
[old style guide]: https://github.com/rust-lang/rust/wiki/Note-style-guide/73c864a10a8e231e2a6630e5a3461f1d3022a20a
Jarcho pushed a commit to Jarcho/rust that referenced this issue Aug 29, 2022
@bors
Auto merge of rust-lang#8696 - J-ZhengLi:issue8492, r=flip1995
87b3afc 
check for if-some-or-ok-else-none-or-err

fixes: rust-lang#8492

---

changelog: make [`option_if_let_else`] to check for match expression with both Option and Result; **TODO: Change lint name? Add new lint with similar functionality?**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust the error messages to match the pattern "expected foo, found bar"
1 participant
@kud1ing