Skip to content

rustdoc: toggles for trait methods are in wrong position #85167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsha opened this issue May 11, 2021 · 0 comments · Fixed by #85280
Closed

rustdoc: toggles for trait methods are in wrong position #85167

jsha opened this issue May 11, 2021 · 0 comments · Fixed by #85280
Labels
A-rustdoc-js Area: Rustdoc's JS front-end C-bug Category: This is a bug.

Comments

@jsha
Copy link
Contributor

jsha commented May 11, 2021

Nightly:

image

https://doc.rust-lang.org/nightly/std/io/trait.Read.html#tymethod.read

Stable:

image

https://doc.rust-lang.org/std/io/trait.Read.html#tymethod.read
@jsha jsha added C-bug Category: This is a bug. A-rustdoc-js Area: Rustdoc's JS front-end labels May 11, 2021
This was referenced May 12, 2021
Merged
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 18, 2021
@GuillaumeGomez
Rollup merge of rust-lang#85280 - jsha:move-trait-toggles, r=Guillaum…
183e5cb 
…eGomez

Toggle-wrap items differently than top-doc.

This makes sure things like trait methods get wrapped at the
`<h3><code>` level rather than at the `.docblock` level. Also it ensures
that only the actual top documentation gets the `.top-doc` class.

Fixes rust-lang#85167

Before:

![image](https://user-images.githubusercontent.com/220205/117743384-98790200-b1bb-11eb-8804-588530842514.png)

https://doc.rust-lang.org/nightly/std/io/trait.Read.html#tymethod.read

After:

![image](https://user-images.githubusercontent.com/220205/118410882-98a75080-b646-11eb-949d-ca688bab6923.png)
@bors bors closed this as completed in d151ed8 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-js Area: Rustdoc's JS front-end C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Toggle-wrap items differently than top-doc. jsha/rust
1 participant
@jsha