Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For 1.53, must fwd-port RUSTC_FORCE_INCREMENTAL from 1.52.1 #86004

Closed
pnkfelix opened this issue Jun 4, 2021 · 0 comments
Closed

For 1.53, must fwd-port RUSTC_FORCE_INCREMENTAL from 1.52.1 #86004

pnkfelix opened this issue Jun 4, 2021 · 0 comments
Assignees
@pnkfelix
Labels
P-critical Critical priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.53.0

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Jun 4, 2021

This is part of #84970.

The T-compiler team decided in the 28 may 2021 steering meeting, based in part on the discussions logged in the associated hackmd document that we would forward port the RUSTC_FORCE_INCREMENTAL flag, which landed to 1.52.1, forward to version 1.53-stable.

@Mark-Simulacrum recommended today that I file an issue to track the forward-port and milestone. That's what this issue is. :)
@pnkfelix pnkfelix added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 4, 2021
@pnkfelix pnkfelix added this to the 1.53.0 milestone Jun 4, 2021
@pnkfelix pnkfelix self-assigned this Jun 4, 2021
@pnkfelix pnkfelix added the P-critical Critical priority label Jun 4, 2021
This was referenced Jun 14, 2021
Open
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 15, 2021
@bors
Auto merge of rust-lang#86317 - Mark-Simulacrum:stable-next, r=Mark-S…
dbe03e2 
…imulacrum

[stable] 1.53.0 release

This includes a backport of:

* Revert "implement TrustedRandomAccess for Take iterator adapter" rust-lang#85975

And includes patches to:

* Update release notes to reflect rust-lang#85541
* Require RUSTC_FORCE_INCREMENTAL to truly enable incremental, fixing rust-lang#86004
* This reverts alignment-related commits to address issue rust-lang#85713 on beta.

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

Labels
P-critical Critical priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

No branches or pull requests
2 participants
@pnkfelix @Mark-Simulacrum