Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for Bound::map #86026

Closed
1 of 3 tasks
glittershark opened this issue Jun 5, 2021 · 6 comments · Fixed by #118361
Closed
1 of 3 tasks

Tracking Issue for Bound::map #86026

glittershark opened this issue Jun 5, 2021 · 6 comments · Fixed by #118361
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@glittershark
Copy link
Contributor

Feature gate: #![feature(bound_map)]

This is a tracking issue for providing a map method on Bound. This method calls a function on the contained value of a Bound (including both Included and Exclcuded, returning a Bound of the same kind.

Public API

impl<T> Bound<T> {
    pub fn map<U, F: FnOnce(T) -> U>(self, f: F) -> Bound<U>;
}

Steps / History

Unresolved Questions

  • None yet.
@glittershark glittershark added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 5, 2021
@bonsairobo
Copy link

What's the time frame for the final commenting period? I'd like to use this API.

@Amanieu
Copy link
Member

Amanieu commented Dec 5, 2023

This seems to be a generally useful method and a use case was presented in #83646 (comment).

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Dec 5, 2023

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 5, 2023
@m-ou-se m-ou-se removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Dec 12, 2023
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 12, 2023
@rfcbot
Copy link

rfcbot commented Dec 12, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 22, 2023
@rfcbot
Copy link

rfcbot commented Dec 22, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Dec 28, 2023
@Ekleog
Copy link

Ekleog commented Jan 14, 2024

Linking this here in case others didn't notice the stabilization PR, as it's above the FCP completion message: the stabilization PR is available at #118361 :)

@bors bors closed this as completed in 304a17a Jan 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 16, 2024
Rollup merge of rust-lang#118361 - Dylan-DPC:80626/stab/bound-map, r=Amanieu

stabilise bound_map

Closes rust-lang#86026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants