Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rustdoc files again for error index page #86512

Closed
GuillaumeGomez opened this issue Jun 21, 2021 · 1 comment · Fixed by #86663
Closed

Use rustdoc files again for error index page #86512

GuillaumeGomez opened this issue Jun 21, 2021 · 1 comment · Fixed by #86663
Assignees
@fee1-dead
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jun 21, 2021 •
edited by rustbot
Loading

#86503 made a small fix for the error index page, but it's still very likely that it'll break in no time because of it's not using rustdoc's style directly. Instead, we should keep specific style for this page in rust.css and use the "normal" rustdoc style for the rest.
@GuillaumeGomez GuillaumeGomez added A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc labels Jun 21, 2021
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed T-rustdoc-temp labels Jun 22, 2021
@fee1-dead
Copy link
Member

@rustbot claim

@fee1-dead fee1-dead mentioned this issue Jun 27, 2021
Merged
@bors bors closed this as completed in c54895b Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fee1-dead fee1-dead

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use rustdoc.css for error index fee1-dead-contrib/rust
3 participants
@GuillaumeGomez @jyn514 @fee1-dead