Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: trait implementors don't have assoc. types shown #86631

Closed
cynecx opened this issue Jun 25, 2021 · 11 comments · Fixed by #88490
Closed

rustdoc: trait implementors don't have assoc. types shown #86631

cynecx opened this issue Jun 25, 2021 · 11 comments · Fixed by #88490
Labels
C-bug Category: This is a bug. P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone
1.55.0

Comments

@cynecx
Copy link
Contributor

cynecx commented Jun 25, 2021

Live: https://doc.rust-lang.org/nightly/std/iter/trait.IntoIterator.html#impl-IntoIterator-30

Trait implementors don't have their assoc. types shown (stable -> nightly regression).

nightly:

image

stable:

image

rustdoc 1.55.0-nightly (7c3872e6b 2021-06-24)
@cynecx cynecx added the C-bug Category: This is a bug. label Jun 25, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 26, 2021

This was intentional in #85970. cc @jsha

@jyn514 jyn514 added this to the 1.55.0 milestone Jun 26, 2021
@jyn514 jyn514 changed the title rustdoc (nightly): trait implementors don't have assoc. types shown rustdoc: trait implementors don't have assoc. types shown Jun 26, 2021
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 26, 2021
@cynecx
Copy link
Contributor Author

cynecx commented Jul 9, 2021

Well, the PR title/description says something different:

Remove methods under Implementors on trait pages

It’s about removing the methods. Personally, that sounds fine. But why did the PR remove the whole section including associated types. To me that’s a really valuable insight/convenience.

@jyn514
Copy link
Member

jyn514 commented Jul 10, 2021

Ah, I see. Yes, I agree only the methods should have been removed.

@jyn514 jyn514 added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Jul 10, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 10, 2021
@apiraino
Copy link
Contributor

Assigning priority as discussed in the Zulip thread of the Prioritization Working Group.

@rustbot label -I-prioritize +P-high

@rustbot rustbot added P-high High priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jul 11, 2021
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 12, 2021 •
edited
Loading

There is #87035 open to fix implementors display already (but not put back assoc types yet). I can fix it once this #87035 has been merged.

@camelid
Copy link
Member

camelid commented Jul 17, 2021 •
edited
Loading

triage: It looks like #87035 has been merged now, so this should be unblocked.

@cynecx
Copy link
Contributor Author

cynecx commented Jul 31, 2021 •
edited
Loading

Can we perhaps revert #85970 for the time being until this gets resolved?

@camelid camelid added regression-from-stable-to-beta Performance or correctness regression from stable to beta. and removed regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. labels Aug 17, 2021
@Mark-Simulacrum
Copy link
Member

@rust-lang/rustdoc are we expecting this to get fixed in 1.55? We'll want to land and backport a fix in the next ~week if that's going to happen.

@GuillaumeGomez
Copy link
Member

It's on my list. I'll try to speed up.

@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 30, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 1, 2021
@GuillaumeGomez
Rollup merge of rust-lang#88490 - GuillaumeGomez:associated-types-imp…
9d052cb 
…lementors-display, r=camelid,Manishearth

Display associated types of implementors

Fixes rust-lang#86631.

Contrary to before, it doesn't display methods. I also had to "resurrect" the `auto-hide-trait-implementations` setting. :3

Only question at this point: should I move the `render_impl` boolean arguments into one struct? We're starting to have quite a lot of them...

cc `@cynecx`
r? `@camelid`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 1, 2021
@GuillaumeGomez
Rollup merge of rust-lang#88490 - GuillaumeGomez:associated-types-imp…
d396e0d 
…lementors-display, r=camelid,Manishearth

Display associated types of implementors

Fixes rust-lang#86631.

Contrary to before, it doesn't display methods. I also had to "resurrect" the `auto-hide-trait-implementations` setting. :3

Only question at this point: should I move the `render_impl` boolean arguments into one struct? We're starting to have quite a lot of them...

cc ``@cynecx``
r? ``@camelid``
@bors bors closed this as completed in 767edcf Sep 2, 2021
@camelid
Copy link
Member

camelid commented Sep 2, 2021

Reopening to track beta backport.

@camelid camelid reopened this Sep 2, 2021
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Sep 4, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 4, 2021
@bors
Auto merge of rust-lang#88641 - Mark-Simulacrum:beta-next, r=Mark-Sim…
e721434 
…ulacrum

[beta] backports

This PR backports:

* Concrete regions can show up in mir borrowck if the originated from there rust-lang#88533 (fixes rust-lang#83190)
* Fix loading large rlibs rust-lang#88506 (fixes rust-lang#88351)
* Display associated types of implementors rust-lang#88490 (fixes rust-lang#86631)
* Tracking issue for UNSUPPORTED_CALLING_CONVENTIONS rust-lang#88397

r? `@Mark-Simulacrum`
@Mark-Simulacrum
Copy link
Member

Closing - backported in #88641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging a pull request may close this issue.

Display associated types of implementors GuillaumeGomez/rust
7 participants
@GuillaumeGomez @Mark-Simulacrum @cynecx @apiraino @jyn514 @camelid @rustbot