Skip to content

Change extra::json::to_xxx(&Json) methods to extra::json::Json::to_xxx(&self) #8676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brandonson opened this issue Aug 21, 2013 · 0 comments · Fixed by #8679
Closed

Change extra::json::to_xxx(&Json) methods to extra::json::Json::to_xxx(&self) #8676

brandonson opened this issue Aug 21, 2013 · 0 comments · Fixed by #8679

Comments

@brandonson
Copy link
Contributor

Several methods in extra::json take a Json reference as a parameter. These should probably be moved into an impl for Json to stay consistent with other parts of the library.
@brandonson brandonson mentioned this issue Aug 22, 2013
Merged
@bors bors closed this as completed in 424e8f0 Aug 24, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 21, 2022
@bors
Auto merge of rust-lang#8676 - Alexendoo:local-used-across-loop, r=xF…
38ba055 
…rednet

Check for loops/closures in `local_used_after_expr`

Follow up to rust-lang#8646, catches when a local is used multiple times because it's in a loop or a closure

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change json::to_xxx(&Json) functions to be json::Json::to_xxx(&self) brandonson/rust
1 participant
@brandonson