Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc is being documented without --document-private-items on nightly-rustc #86900

Closed
jyn514 opened this issue Jul 6, 2021 · 1 comment · Fixed by #86913
Closed

Rustdoc is being documented without --document-private-items on nightly-rustc #86900

jyn514 opened this issue Jul 6, 2021 · 1 comment · Fixed by #86913
Assignees
@Stupremee
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Jul 6, 2021 •
edited by rustbot
Loading

Compare https://doc.rust-lang.org/beta/nightly-rustc/rustdoc/ to https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/.

This is almost certainly caused by #86737.
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Jul 6, 2021
@Stupremee
Copy link
Member

@rustbot claim

@Stupremee Stupremee mentioned this issue Jul 6, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 8, 2021
@GuillaumeGomez
Rollup merge of rust-lang#86913 - Stupremee:document-rustdoc-private-…
a3649bc 
…items, r=jyn514

Document rustdoc with `--document-private-items`

The `tool_doc` macro introduced in rust-lang#86737 did not use `false` as the default value for `binary` when it is not provided, so the `if` is not even expanded and thus the argument is never provided if the `binary` argument isn't.

Resolves rust-lang#86900

r? `@Mark-Simulacrum`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 8, 2021
@GuillaumeGomez
Rollup merge of rust-lang#86913 - Stupremee:document-rustdoc-private-…
c352b59 
…items, r=jyn514

Document rustdoc with `--document-private-items`

The `tool_doc` macro introduced in rust-lang#86737 did not use `false` as the default value for `binary` when it is not provided, so the `if` is not even expanded and thus the argument is never provided if the `binary` argument isn't.

Resolves rust-lang#86900

r? ``@Mark-Simulacrum``
@bors bors closed this as completed in e30eb4d Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stupremee Stupremee

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document rustdoc with --document-private-items Stupremee/rust
2 participants
@jyn514 @Stupremee