Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] submodules = false no longer skips updating LLVM submodule #86954

Closed
durin42 opened this issue Jul 7, 2021 · 0 comments · Fixed by #87049
Closed

[build] submodules = false no longer skips updating LLVM submodule #86954

durin42 opened this issue Jul 7, 2021 · 0 comments · Fixed by #87049
Assignees
@jyn514
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@durin42
Copy link
Contributor

durin42 commented Jul 7, 2021

After #86015 there's once again (see #85647) no way to prevent the build system from force-updating the LLVM submodule, which is a problem if you're trying to experiment with LLVM patches.
@durin42 durin42 mentioned this issue Jul 7, 2021
Merged
@jyn514 jyn514 self-assigned this Jul 7, 2021
@jyn514 jyn514 added A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Jul 7, 2021
This was referenced Jul 10, 2021
Merged
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Jul 11, 2021
@Dylan-DPC
Rollup merge of rust-lang#87049 - jyn514:no-submodules, r=Mark-Simula…
37e34ee 
…crum

Account for `submodules = false` in config.toml when updating LLVM submodule

Fixes rust-lang#86954.

r? `@Mark-Simulacrum` cc `@durin42`
@bors bors closed this as completed in f3d5fde Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyn514 jyn514

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Account for submodules = false in config.toml when updating LLVM submodule jyn514/rust
2 participants
@durin42 @jyn514