Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monomorphize normalization is broken #8720

Closed
thestinger opened this issue Aug 23, 2013 · 0 comments
Closed

monomorphize normalization is broken #8720

thestinger opened this issue Aug 23, 2013 · 0 comments

Comments

@thestinger
Copy link
Contributor

It normalizes types and then results in invalid function calls due to non-matching parameter types. This is causing the performance regression in #8665.

With normalization on:

test bench_insert_find_remove_std ... bench: 108310 ns/iter (+/- 5073)
test bench_insert_std ... bench: 55899 ns/iter (+/- 1959)

With it disabled:

test bench_insert_find_remove_std ... bench: 81217 ns/iter (+/- 5434)
test bench_insert_std ... bench: 42963 ns/iter (+/- 1894)

bors added a commit that referenced this issue Aug 24, 2013
Monomorphize's normalization results in a 2% decrease in non-optimized
code size for libstd, so there's a negligible cost to removing it. This
also fixes several visit glue bugs because normalize wasn't considering
the differences in visit glue between types.

Closes #8720
flip1995 pushed a commit to flip1995/rust that referenced this issue May 5, 2022
…endoo,xFrednet

fix ICE in `cast_slice_different_sizes`

fixes rust-lang#8708

changelog: fixes an ICE introduced in rust-lang#8445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant