Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Regression in width of stability (etc.) banners #87202

Closed
camelid opened this issue Jul 16, 2021 · 10 comments · Fixed by #87251
Closed

rustdoc: Regression in width of stability (etc.) banners #87202

camelid opened this issue Jul 16, 2021 · 10 comments · Fixed by #87251
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. P-medium Medium priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone

Comments

@camelid
Copy link
Member

camelid commented Jul 16, 2021

I'm not sure if this change is intentional or not, but I thought it's worth reporting in case it's a bug.

nightly (incorrect)

image

beta (correct)

image

@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jul 16, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jul 16, 2021
@camelid
Copy link
Member Author

camelid commented Jul 16, 2021

cc @rust-lang/rustdoc: Was this change intentional?

@Manishearth
Copy link
Member

I don't think so!

@GuillaumeGomez
Copy link
Member

We found it out with @dns2utf8 and we weren't sure whether it was good or not (from a "look" point of view) and simply decided to wait and see if people liked it or not. So, should we revert it or not? :)

@moxian
Copy link
Contributor

moxian commented Jul 17, 2021

As a random person on the internet, I prefer the old look better. Although I admit that's at least partially due to familiarity with it.

@pietroalbini pietroalbini added this to the 1.55.0 milestone Jul 17, 2021
@apiraino
Copy link
Contributor

Assigning priority as discussed in the Zulip thread of the Prioritization Working Group.

@rustbot label -I-prioritize +P-medium

@rustbot rustbot added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jul 17, 2021
@Manishearth
Copy link
Member

@GuillaumeGomez I would revert it

@GuillaumeGomez
Copy link
Member

I'll change the look then.

@inquisitivecrystal
Copy link
Contributor

inquisitivecrystal commented Jul 17, 2021

I think I might like the new look better, but it's a slight preference and I seem to be outvoted. :)

@jyn514
Copy link
Member

jyn514 commented Jul 17, 2021

I don't think we should be changing the UI by accident. I'm open to a discussion in changing it, but it shouldn't have changed without a discussion, so we should change it back in the meantime.

@GuillaumeGomez
Copy link
Member

Agreed. I'll send a fix in the next two days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. P-medium Medium priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants