Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jemalloc broken on win32 #8731

Closed
klutzy opened this issue Aug 24, 2013 · 1 comment
Closed

jemalloc broken on win32 #8731

klutzy opened this issue Aug 24, 2013 · 1 comment

Comments

@klutzy
Copy link
Contributor

klutzy commented Aug 24, 2013

I experienced build failure during #8662, and I've heard same problem today at irc.
Here's the failure log.
Seems like configure failed to find definitions for win32. (#error "No size class definitions match configuration")
@klutzy klutzy mentioned this issue Aug 24, 2013
Closed
mukilan added a commit to mukilan/rust that referenced this issue Aug 24, 2013
@mukilan
Force line ending of '.in' files in jemalloc to LF
dad2ccc 
This fixes issue rust-lang#8731 . On Windows, if the git option core.autocrlf is true (github recommends users to turn on this flag - see https://help.github.com/articles/dealing-with-line-endings), the headers generated from the .in files will have syntatic errors, causing compilation to fail.
@mukilan mukilan mentioned this issue Aug 24, 2013
Merged
@klutzy
Copy link
Contributor Author

klutzy commented Aug 28, 2013

For record: it is due to CRLF (wow!), and #8738 fixes it by force git checkout LF for certain files.
However, the fix does not help if you already checkout out repo before #8738 landed. For those cases, remove jemalloc directory (git rm --force -r src/etc/jemalloc) and checkout again (git checkout src/etc/jemalloc).

@klutzy klutzy mentioned this issue Sep 15, 2013
Closed
@klutzy klutzy mentioned this issue Apr 23, 2015
Closed
flip1995 pushed a commit to flip1995/rust that referenced this issue May 5, 2022
@bors
Auto merge of rust-lang#8731 - Alexendoo:dogfood-allow-unknown-lints,…
cef882c 
… r=xFrednet

dogfood: allow unknown lints when not running with `internal` feature

changelog: none

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/unknown.20lint.20in.20test.20dogfood_clippy

It's only a warning so this wasn't causing the test to fail, but if you had another error somewhere or used `--nocapture` the extra warnings would be shown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thestinger @klutzy