Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{f32,f64,float}::tests::test_frexp unit tests in libstd fail on Windows #8755

Closed
vadimcn opened this issue Aug 26, 2013 · 5 comments
Closed

{f32,f64,float}::tests::test_frexp unit tests in libstd fail on Windows #8755

vadimcn opened this issue Aug 26, 2013 · 5 comments
Labels
O-windows Operating system: Windows

Comments

@vadimcn
Copy link
Contributor

vadimcn commented Aug 26, 2013

SImilarly to #8663, looks like mingw32 implementation of frexp() violates the spec when dealing with +/-infinity.
@thestinger thestinger mentioned this issue Nov 6, 2013
Merged
@alexcrichton
Copy link
Member

This has not been fixed by upgrading to mingw-w64

@brson brson mentioned this issue Aug 12, 2014
Closed
33 tasks
@steveklabnik
Copy link
Member

@retep998 do you know if this is still an issue? I'm not aware of tests failing.

@retep998
Copy link
Member

retep998 commented Sep 3, 2015

I have no idea. I'm not an expert on the precise behavior of the math functions.

@steveklabnik
Copy link
Member

I guess I meant if you had seen test failures, not the details of them failing.

@steveklabnik
Copy link
Member

Given that there's been no substantial comments here in years, I'm going to consider this one stale; please let me know if this is somehow reproducible today.

flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 14, 2023
@bors
Auto merge of rust-lang#10924 - est31:manual_let_else_question_mark, …
3f17c5c 
…r=Centri3,flip1995,Manishearth

Don't lint manual_let_else in cases where ? would work

Don't lint `manual_let_else` where the question mark operator `?` would be sufficient, that is, mostly in cases like:

```Rust
let v = if let Some(v) = ex { v } else { return None };
```

Also, this PR emits the `question_mark` lint for `let...else` patterns that could be written with `?` (also, only `return None` like cases).

```
changelog: [`manual_let_else`]: don't lint in cases where question_mark already lints
changelog: [`question_mark`]: lint for `let Some(...) = ex else { return None };`
```

Fixes  rust-lang#8755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @alexcrichton @retep998 @vadimcn