porting writeback.rs to new <V:Visitor> injects rt/uv failure

[pnkfelix]

The commit that holds the mechanical port of oldvisit to <V:Visitor>:

pnkfelix@44cda23

Configure flags:

CFG_CONFIGURE_ARGS   := --enable-debug --enable-optimize --enable-ccache --enable-clang --prefix=~/opt/rust-dbg

During make check-full, it dies with:

run rpass [x86_64-apple-darwin]: x86_64-apple-darwin/stage1/bin/compiletest

running 1304 tests
/bin/sh: line 1: 78143 Abort trap: 6           x86_64-apple-darwin/stage1/bin/compiletest --compile-lib-path x86_64-apple-darwin/stage1/lib --run-lib-path x86_64-apple-darwin/stage1/lib/rustc/x86_64-apple-darwin/lib --rustc-path x86_64-apple-darwin/stage1/bin/rustc --clang-path /Users/fklock/bin/clang++ --llvm-bin-path /Users/fklock/Dev/Mozilla/rust.git/objdir-dbgopt/llvm/x86_64-apple-darwin/Release+Asserts/bin --aux-base /Users/fklock/Dev/Mozilla/rust.git/src/test/auxiliary/ --stage-id stage1-x86_64-apple-darwin --target x86_64-apple-darwin --adb-path= --adb-test-dir= --rustcflags "   --cfg rtopt  -O --target=x86_64-apple-darwin" --src-base /Users/fklock/Dev/Mozilla/rust.git/src/test/run-pass/ --build-base x86_64-apple-darwin/test/run-pass/ --ratchet-metrics tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rpass-metrics.json --mode run-pass --logfile tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rpass.log
make: *** [tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rpass.ok] Error 134

Under gdb, here's the stack trace:

(gdb) r --compile-lib-path x86_64-apple-darwin/stage1/lib --run-lib-path x86_64-apple-darwin/stage1/lib/rustc/x86_64-apple-darwin/lib --rustc-path x86_64-apple-darwin/stage1/bin/rustc --clang-path /Users/fklock/bin/clang++ --llvm-bin-path /Users/fklock/Dev/Mozilla/rust.git/objdir-dbgopt/llvm/x86_64-apple-darwin/Release+Asserts/bin --aux-base /Users/fklock/Dev/Mozilla/rust.git/src/test/auxiliary/ --stage-id stage1-x86_64-apple-darwin --target x86_64-apple-darwin --adb-path= --adb-test-dir= --rustcflags "   --cfg rtopt  -O --target=x86_64-apple-darwin" --src-base /Users/fklock/Dev/Mozilla/rust.git/src/test/run-pass/ --build-base x86_64-apple-darwin/test/run-pass/ --ratchet-metrics tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rpass-metrics.json --mode run-pass --logfile tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rpass.log
Starting program: /Users/fklock/Dev/Mozilla/rust.git/objdir-dbgopt/x86_64-apple-darwin/stage1/bin/compiletest --compile-lib-path x86_64-apple-darwin/stage1/lib --run-lib-path x86_64-apple-darwin/stage1/lib/rustc/x86_64-apple-darwin/lib --rustc-path x86_64-apple-darwin/stage1/bin/rustc --clang-path /Users/fklock/bin/clang++ --llvm-bin-path /Users/fklock/Dev/Mozilla/rust.git/objdir-dbgopt/llvm/x86_64-apple-darwin/Release+Asserts/bin --aux-base /Users/fklock/Dev/Mozilla/rust.git/src/test/auxiliary/ --stage-id stage1-x86_64-apple-darwin --target x86_64-apple-darwin --adb-path= --adb-test-dir= --rustcflags "   --cfg rtopt  -O --target=x86_64-apple-darwin" --src-base /Users/fklock/Dev/Mozilla/rust.git/src/test/run-pass/ --build-base x86_64-apple-darwin/test/run-pass/ --ratchet-metrics tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rpass-metrics.json --mode run-pass --logfile tmp/check-stage1-T-x86_64-apple-darwin-H-x86_64-apple-darwin-rpass.log

running 1304 tests
task <unnamed> failed at 'assertion failed: handle.is_not_null()', /Users/fklock/Dev/Mozilla/rust.git/src/libstd/rt/uv/mod.rs:100

Program received signal SIGABRT, Aborted.
[Switching to process 79067 thread 0x11c03]
0x00007fff88cad212 in __pthread_kill ()
(gdb) bt
#0  0x00007fff88cad212 in __pthread_kill ()
#1  0x00007fff8b460b54 in pthread_kill ()
#2  0x00007fff8b4a4dce in abort ()
#3  0x000000010089abdc in uv__loop_init ()
#4  0x0000000100897f3c in uv_loop_new ()
#5  0x00000001001230f3 in rust_uv_loop_new__c_stack_shim ()
#6  0x000000010011fb9d in rt::uv::uvll::loop_new::_2e56944dfc7111c3::_0$x2e8$x2dpre ()
#7  0x0000000100103a36 in rt::uv::__extensions__::meth_32166::new::_6258a64324bd1e4::_0$x2e8$x2dpre ()
#8  0x0000000100098f0d in task::spawn::spawn_raw::_756be165ba664c33::_0$x2e8$x2dpre ()
#9  0x00000001000a81a6 in task::__extensions__::meth_23511::spawn::_3de8d92fd336c7d3::_0$x2e8$x2dpre ()
#10 0x00000001000a8c69 in task::spawn_sched::_af1f9ed53fee60af::_0$x2e8$x2dpre ()
#11 0x00000001000c1c1f in run::__extensions__::meth_25091::finish_with_output::_a0af1686bf6879f5::_0$x2e8$x2dpre ()
#12 0x0000000100000bd5 in procsrv::run::_3ce3d3738d51ffb6::_0$x2e0 ()
#13 0x0000000100015373 in runtest::program_output::_9f44746e0208140::_0$x2e0 ()
#14 0x000000010000d3c0 in runtest::compose_and_run::_138a5694a085567a::_0$x2e0 ()
#15 0x000000010000dd4f in runtest::compose_and_run_compiler::_9cc8b33a42b79955::_0$x2e0 ()
#16 0x0000000100010b54 in runtest::compile_test_::_24127cd16e23dfa3::_0$x2e0 ()
#17 0x0000000100007d49 in runtest::run_rpass_test::_b66d68ab31e3caa0::_0$x2e0 ()
#18 0x00000001000056c2 in runtest::run_metrics::_a870c736ae138be0::_0$x2e0 ()
#19 0x0000000100005989 in runtest::run::anon::expr_fn_6872 ()
#20 0x000000010009aee5 in task::spawn::spawn_raw::anon::expr_fn_22016 ()
#21 0x00000001000e39be in rt::task::__extensions__::build_start_wrapper::anon::anon::expr_fn_29228 ()
#22 0x00000001000e27fd in rt::task::__extensions__::run::anon::expr_fn_29150 ()
#23 0x00000001000e3cbd in rt::task::__extensions__::try_fn::_beda23fdd249604d::_0$x2e8$x2dpre ()
#24 0x000000010088c7f3 in rust_try (f=<value temporarily unavailable, due to optimizations>, fptr=<value temporarily unavailable, due to optimizations>, env=<value temporarily unavailable, due to optimizations>) at rust_builtin.cpp:520
#25 0x00000001000e26b4 in rt::task::__extensions__::meth_29148::try::_199ab8d6eb226980::_0$x2e8$x2dpre ()
#26 0x00000001000e2595 in rt::task::__extensions__::meth_29146::run::_199ab8d6eb226980::_0$x2e8$x2dpre ()
#27 0x00000001000e36bc in rt::task::__extensions__::build_start_wrapper::anon::expr_fn_29212 ()
#28 0x000000010012ab99 in rt::context::__extensions__::task_start_wrapper::_d625afdc49afb93::_0$x2e8$x2dpre ()
(gdb) 

[nikomatsakis]

Interesting...

[pnkfelix]

(note that this blocks #7081)

[pnkfelix]

okay.... apparently bors eventually let #9086 through, so I will close this. :)