Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird sentence in comments in src/test/ui/pattern/bindings-after-at/nested-type-ascription-syntactically-invalid.rs #88233

Closed
steffahn opened this issue Aug 22, 2021 · 1 comment · Fixed by #89777
Closed

Weird sentence in comments in src/test/ui/pattern/bindings-after-at/nested-type-ascription-syntactically-invalid.rs #88233

steffahn opened this issue Aug 22, 2021 · 1 comment · Fixed by #89777
Assignees
@pierwill
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@steffahn
Copy link
Member

steffahn commented Aug 22, 2021 •
edited by rustbot
Loading

rust/src/test/ui/pattern/bindings-after-at/nested-type-ascription-syntactically-invalid.rs

Lines 1 to 2 in 998cfe5

// Here we check that type ascription is syntactically invalid when
// not in the top position of a ascribing a let binding or function parameter.

In the sentence above, I’m unable to figure out the grammatical role of the word “ascribing” and the two “a”s.

I’m not immediately sure how to best fix it without changing the meaning so something that isn’t meant.

Found while doing #88230

@rustbot label T-compiler
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 22, 2021
@pierwill
Copy link
Member

@rustbot claim

@pierwill pierwill mentioned this issue Oct 11, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Oct 13, 2021
@JohnTitor
Rollup merge of rust-lang#89777 - pierwill:fix-88233, r=Mark-Simulacrum
9ef50f9 
Edit explanation of test for nested type ascriptions

Fixes typo ("an ascribing") and removes extra.

Closes rust-lang#88233.
the8472 added a commit to the8472/rust that referenced this issue Oct 13, 2021
@the8472
Rollup merge of rust-lang#89777 - pierwill:fix-88233, r=Mark-Simulacrum
1d63deb 
Edit explanation of test for nested type ascriptions

Fixes typo ("an ascribing") and removes extra.

Closes rust-lang#88233.
JohnTitor added a commit to JohnTitor/rust that referenced this issue Oct 13, 2021
@JohnTitor
Rollup merge of rust-lang#89777 - pierwill:fix-88233, r=Mark-Simulacrum
cd5fe93 
Edit explanation of test for nested type ascriptions

Fixes typo ("an ascribing") and removes extra.

Closes rust-lang#88233.
@bors bors closed this as completed in e71d17b Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierwill pierwill

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit explanation of test for nested type ascriptions pierwill/rust
3 participants
@steffahn @pierwill @rustbot