Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"jump to definition" feature is generating links to private item documentation pages #88304

Closed
GuillaumeGomez opened this issue Aug 24, 2021 · 2 comments · Fixed by #88619
Closed

"jump to definition" feature is generating links to private item documentation pages #88304

GuillaumeGomez opened this issue Aug 24, 2021 · 2 comments · Fixed by #88619
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

More information on #88292
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Aug 24, 2021
@GuillaumeGomez GuillaumeGomez self-assigned this Aug 24, 2021
@jyn514
Copy link
Member

jyn514 commented Aug 24, 2021

To be clear, I'm not actually sure that's a private link, I didn't look at it in detail. It might just be doc(hidden) or something.

@GuillaumeGomez
Copy link
Member Author

I didn't either. Just that most of weird things happening are in os.

@GuillaumeGomez GuillaumeGomez mentioned this issue Sep 3, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 11, 2021
@GuillaumeGomez
Rollup merge of rust-lang#88619 - GuillaumeGomez:simplify-std-os-reex…
e0f6ff4 
…ports, r=Amanieu

Remove `cfg(doc)` from std::os module reexports to fix rustdoc linking issues

Fixes rust-lang#88304.

I tested it based on rust-lang#88292.

Not sure if it's the best approach, but at least it makes thing a bit simpler.

cc `@jyn514`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 11, 2021
@GuillaumeGomez
Rollup merge of rust-lang#88619 - GuillaumeGomez:simplify-std-os-reex…
f064ad7 
…ports, r=Amanieu

Remove `cfg(doc)` from std::os module reexports to fix rustdoc linking issues

Fixes rust-lang#88304.

I tested it based on rust-lang#88292.

Not sure if it's the best approach, but at least it makes thing a bit simpler.

cc ``@jyn514``
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Sep 12, 2021
@workingjubilee
Rollup merge of rust-lang#88619 - GuillaumeGomez:simplify-std-os-reex…
9116186 
…ports, r=Amanieu

Remove `cfg(doc)` from std::os module reexports to fix rustdoc linking issues

Fixes rust-lang#88304.

I tested it based on rust-lang#88292.

Not sure if it's the best approach, but at least it makes thing a bit simpler.

cc `@jyn514`
Manishearth added a commit to Manishearth/rust that referenced this issue Sep 14, 2021
@Manishearth
Rollup merge of rust-lang#88619 - GuillaumeGomez:simplify-std-os-reex…
8be84a9 
…ports, r=Amanieu

Remove `cfg(doc)` from std::os module reexports to fix rustdoc linking issues

Fixes rust-lang#88304.

I tested it based on rust-lang#88292.

Not sure if it's the best approach, but at least it makes thing a bit simpler.

cc ``@jyn514``
Manishearth added a commit to Manishearth/rust that referenced this issue Sep 14, 2021
@Manishearth
Rollup merge of rust-lang#88619 - GuillaumeGomez:simplify-std-os-reex…
44cafcd 
…ports, r=Amanieu

Remove `cfg(doc)` from std::os module reexports to fix rustdoc linking issues

Fixes rust-lang#88304.

I tested it based on rust-lang#88292.

Not sure if it's the best approach, but at least it makes thing a bit simpler.

cc ```@jyn514```
Manishearth added a commit to Manishearth/rust that referenced this issue Sep 14, 2021
@Manishearth
Rollup merge of rust-lang#88619 - GuillaumeGomez:simplify-std-os-reex…
3cd22f9 
…ports, r=Amanieu

Remove `cfg(doc)` from std::os module reexports to fix rustdoc linking issues

Fixes rust-lang#88304.

I tested it based on rust-lang#88292.

Not sure if it's the best approach, but at least it makes thing a bit simpler.

cc ````@jyn514````
@bors bors closed this as completed in e846f9c Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove cfg(doc) from std::os module reexports to fix rustdoc linking issues GuillaumeGomez/rust
2 participants
@GuillaumeGomez @jyn514