Skip to content

rustdoc: Ayu syntax highlighting regression #88415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
camelid opened this issue Aug 28, 2021 · 3 comments · Fixed by #88419
Closed

rustdoc: Ayu syntax highlighting regression #88415

camelid opened this issue Aug 28, 2021 · 3 comments · Fixed by #88419
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone
1.56.0

Comments

@camelid
Copy link
Member

camelid commented Aug 28, 2021

My guess is that the yellow inline code style is incorrectly being applied to code blocks too.

Nightly (incorrect)

image

Beta & stable (correct)

image
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Aug 28, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 28, 2021
@camelid
Copy link
Member Author

camelid commented Aug 28, 2021

cc @GuillaumeGomez since you're knowledgeable about rustdoc's CSS

@GuillaumeGomez
Copy link
Member

I'll send a fix shortly.

@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 28, 2021
Merged
@camelid camelid added this to the 1.56.0 milestone Aug 28, 2021
@camelid
Copy link
Member Author

camelid commented Aug 28, 2021

#88093 looks to be the likely cause.

searched nightlies: from nightly-2021-07-01 to nightly-2021-08-25
regressed nightly: nightly-2021-08-20
searched commits: from 3d0774d to 6d64f7f
regressed commit: 6d64f7f

bisected with cargo-bisect-rustc v0.6.0

Host triple: x86_64-apple-darwin
Reproduce with:

cargo bisect-rustc --start=2021-07-01 --end=2021-08-25 --preserve --prompt -- doc --open

@bors bors closed this as completed in 26feefd Aug 29, 2021
@camelid camelid removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging a pull request may close this issue.

Fix code blocks color in Ayu theme GuillaumeGomez/rust
3 participants
@GuillaumeGomez @camelid @rustbot