-
Notifications
You must be signed in to change notification settings - Fork 13.3k
ICE when updating tuples #8856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Huh, that's an odd ICE. I was under the impression that rust didn't support destructuring assignment into existing locals. |
It doesn't. :) I should say, that's why I mentioned that the code was wrong in attempting to mutate the immutable parameters (it was converted from Python code where this would be fine). I fixed it by declaring two local mutable shadow vars. The pthread failure is a bit of a worry, too. Haven't had a chance to dig into that yet. |
Opened #8870 to continue discussion about the pthreads failure, that is disturbing... |
For the original issue, closing this as a dupe of #7507 |
Rustup `@rust-lang/clippy,` `@Jarcho,` `@dswij,` `@Alexendoo.` Could someone review this? It should be pretty straight forward since it's just a sync. I think it's also fine if either one of `@Jarcho,` `@dswij,` `@Alexendoo` approves this, as these are usually not reviewed. I just want to make sure that I didn't break something obvious 🙃 It should be enough to look at the merge commit 🙃 changelog: none changelog: move [`significant_drop_in_scrutinee`] to `suspicious`
Playing around with some simple code which is clearly wrong:
This triggered an internal compiler error:
This is running Rust 1ac7d80 on Mac OS X 10.8.4.
Incidentally, when trying to check the version, I noticed this error:
The text was updated successfully, but these errors were encountered: