Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc (unstable): --generate-link-to-definition makes sources unreadable with Ayu theme #88870

Closed
camelid opened this issue Sep 11, 2021 · 1 comment · Fixed by #88885
Closed

rustdoc (unstable): --generate-link-to-definition makes sources unreadable with Ayu theme #88870

camelid opened this issue Sep 11, 2021 · 1 comment · Fixed by #88885
Assignees
@GuillaumeGomez
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. requires-nightly This issue requires a nightly compiler in some way. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Sep 11, 2021

Interestingly, the dark theme works fine.

Screenshot of Ayu:

image

cc @GuillaumeGomez
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. requires-nightly This issue requires a nightly compiler in some way. A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Sep 11, 2021
@GuillaumeGomez GuillaumeGomez self-assigned this Sep 12, 2021
@GuillaumeGomez
Copy link
Member

Sending a fix in the next few hours.

@GuillaumeGomez GuillaumeGomez mentioned this issue Sep 12, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 13, 2021
@GuillaumeGomez
Rollup merge of rust-lang#88885 - GuillaumeGomez:fix-jump-def-backgro…
b59be13 
…und, r=camelid

Fix jump def background

Fixes rust-lang#88870.

I somehow badly wrote the color in rust-lang#88111.

r? `@camelid`
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Sep 14, 2021
@workingjubilee
Rollup merge of rust-lang#88885 - GuillaumeGomez:fix-jump-def-backgro…
2a65d56 
…und, r=camelid

Fix jump def background

Fixes rust-lang#88870.

I somehow badly wrote the color in rust-lang#88111.

r? `@camelid`
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Sep 14, 2021
@workingjubilee
Rollup merge of rust-lang#88885 - GuillaumeGomez:fix-jump-def-backgro…
c3620fa 
…und, r=camelid

Fix jump def background

Fixes rust-lang#88870.

I somehow badly wrote the color in rust-lang#88111.

r? ``@camelid``
@bors bors closed this as completed in f10fc21 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. requires-nightly This issue requires a nightly compiler in some way. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix jump def background GuillaumeGomez/rust
2 participants
@GuillaumeGomez @camelid