Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Remove clean::Type::Never in favor of always using clean::PrimitiveType::Never #89287

Closed
camelid opened this issue Sep 26, 2021 · 1 comment · Fixed by #89297
Closed

rustdoc: Remove clean::Type::Never in favor of always using clean::PrimitiveType::Never #89287

camelid opened this issue Sep 26, 2021 · 1 comment · Fixed by #89297
Assignees
@GuillaumeGomez
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Sep 26, 2021

It's trickier than it sounds; there's some weird rustdoc behavior with Type::Never that will need to be sorted out.
@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Sep 26, 2021
@camelid camelid mentioned this issue Sep 26, 2021
Merged
@GuillaumeGomez
Copy link
Member

I'll take a look. :)

@GuillaumeGomez GuillaumeGomez self-assigned this Sep 27, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue Sep 27, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 29, 2021
@GuillaumeGomez
Rollup merge of rust-lang#89297 - GuillaumeGomez:remove-never-from-ty…
18fd2db 
…pe-enum, r=camelid

Remove Never variant from clean::Type enum

Fixes rust-lang#89287.

r? `@camelid`
@bors bors closed this as completed in 8dfe522 Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Never variant from clean::Type enum GuillaumeGomez/rust
2 participants
@GuillaumeGomez @camelid