Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for -Z no-unique-section-names #90275

Open
2 of 4 tasks
jblazquez opened this issue Oct 25, 2021 · 1 comment
Open
2 of 4 tasks

Tracking Issue for -Z no-unique-section-names #90275

jblazquez opened this issue Oct 25, 2021 · 1 comment
Labels
A-binary-formats Area: binary formats (e.g. ELF, XCOFF, etc.) A-CLI Area: Command-line interface (CLI) to the compiler A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-design-concerns Status: There are blocking design concerns. S-tracking-needs-summary Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jblazquez
Copy link
Contributor

jblazquez commented Oct 25, 2021 •
edited by jieyouxu
Loading

This is a tracking issue for the -Z no-unique-section-names debugging option which can reduce the size of object files for ELF targets when using the LLVM codegen backend.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Implementation steps

Unresolved questions

  • Is this flag supposed to have any effect on non-ELF object files on non-ELF targets?

Implementation history
@jblazquez jblazquez added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Oct 25, 2021
@jblazquez jblazquez mentioned this issue Oct 25, 2021
Merged
@Mark-Simulacrum Mark-Simulacrum added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 25, 2021
@workingjubilee workingjubilee added the A-CLI Area: Command-line interface (CLI) to the compiler label Mar 5, 2023
dcoles added a commit to flipperzero-rs/flipperzero that referenced this issue Mar 13, 2023
@dcoles
Bump toolchain to nightly-2023-03-10
4839224 
We can almost use `stable`, except for requiring
`-Z no-unique-section-names=yes` to ensure that all symbols are located
in a single `.text` section (the Flipper Zero loader does not support
unique section names).

See rust-lang/rust#90275
@dcoles dcoles mentioned this issue Mar 18, 2023
Open
4 tasks
@dcoles
Copy link

dcoles commented Mar 18, 2023 •
edited by Dylan-DPC
Loading

What would the requirements be to stabilise this feature?

Now that Rust 1.68.0 has stabilised #66741 (default alloc error handler), this is the last remaining blocker for supporting a stable toolchain in flipperzero-rs.

@jieyouxu jieyouxu added S-tracking-design-concerns Status: There are blocking design concerns. S-tracking-needs-summary Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation. A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-binary-formats Area: binary formats (e.g. ELF, XCOFF, etc.) labels Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-binary-formats Area: binary formats (e.g. ELF, XCOFF, etc.) A-CLI Area: Command-line interface (CLI) to the compiler A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-design-concerns Status: There are blocking design concerns. S-tracking-needs-summary Status: It's hard to tell what's been done and what hasn't! Someone should do some investigation. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dcoles @Mark-Simulacrum @jblazquez @jieyouxu @workingjubilee