Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Pass Context as a &mut to allow to remove RefCell fields #90323

Closed
GuillaumeGomez opened this issue Oct 26, 2021 · 12 comments · Fixed by #97433
Closed

rustdoc: Pass Context as a &mut to allow to remove RefCell fields #90323

GuillaumeGomez opened this issue Oct 26, 2021 · 12 comments · Fixed by #97433
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Oct 26, 2021 •
edited by rustbot
Loading

It was discussed in #90183 because of the add of the Context::deref_id_map field.
@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 26, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 26, 2021
Merged
@jyn514 jyn514 added E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Oct 30, 2021
@jyn514 jyn514 changed the title Pass Context as a &mut to allow to remove RefCell fields rustdoc: Pass Context as a &mut to allow to remove RefCell fields Oct 30, 2021
@Milo123459
Copy link
Contributor

@rustbot claim

Going to give this one a try!

@Milo123459
Copy link
Contributor

To be clear, I'm removing the RefCell from the types, not removing those fields, right?

@GuillaumeGomez
Copy link
Member Author

Yes.

@jyn514
Copy link
Member

jyn514 commented Nov 30, 2021

Hi @Milo123459, have you had time to work on this? Feel free to ask here or on Zulip if you need help :)

@Milo123459
Copy link
Contributor

I have worked on it pretty actively. The amount of borrowing errors is.. indescribably large.

@jyn514
Copy link
Member

jyn514 commented Nov 30, 2021

@Milo123459 let me see if I can help with that at all :) I pinged you on https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/.26mut.20Context so we can talk with less delay.

@Milo123459
Copy link
Contributor

Fantastic!

@Milo123459 Milo123459 mentioned this issue Dec 2, 2021
Closed
@Milo123459
Copy link
Contributor

Finally made a PR for it! #91468

@Milo123459
Copy link
Contributor

Milo123459 commented May 25, 2022 •
edited
Loading

@rustbot release
Is this not a command? :(

@Milo123459 Milo123459 removed their assignment May 25, 2022
@GuillaumeGomez
Copy link
Member Author

Is this not a command? :(

Apparently not. 😆

I'll take a look to this issue then based on your work.

@GuillaumeGomez GuillaumeGomez mentioned this issue May 26, 2022
Merged
@camelid
Copy link
Member

camelid commented May 26, 2022

@Milo123459 the command is @rustbot release-assignment :)

@Milo123459
Copy link
Contributor

Ahh!

@bors bors closed this as completed in 764b861 May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass Context as a &mut to allow to remove RefCell fields GuillaumeGomez/rust
4 participants
@GuillaumeGomez @jyn514 @camelid @Milo123459