Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The two unsafe functions in std::ascii might be unnecessary. #9058

Closed
Kimundi opened this issue Sep 8, 2013 · 1 comment
Closed

The two unsafe functions in std::ascii might be unnecessary. #9058

Kimundi opened this issue Sep 8, 2013 · 1 comment

Comments

@Kimundi
Copy link
Member

Kimundi commented Sep 8, 2013

PLACEHOLDER: FUNCTIONS ARE PART OF A UNLANDED PULL REQUEST

std::ascii contains the two unsafe functions str_map_bytes and str_copy_map_bytes. Both implement mapping a look up table over an byte vector using unsafe code and pointer arithmetic. It is unclear if that's intentionally done for speed, or whether an more idiomatic implementation using iterators would be just as fast. In case of the latter, the functions should probably be rewritten/removed.
@Kimundi
Copy link
Member Author

Kimundi commented Sep 9, 2013

The functions got rewritten before landing, closing.

@Kimundi Kimundi closed this as completed Sep 9, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 18, 2022
@bors
Auto merge of rust-lang#9058 - xFrednet:changelog-1-62, r=flip1995
2d01959 
Changelog for Rust 1.62 🦖

This special artifact was just discovered. The artifact details changes to something called Clippy. Presently and from the context, we were unable to determine what this is supposed to be. All we know, is that it seems to have an active community around it which supports it. The members sometimes use paper clips as a secret symbol for Clippy.

I want to donate this artifact to the rust-lang organization, to have it displayed to the public.

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kimundi