Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing rustc_incremental::persist::fs::dep_graph_path_from #90658

Closed
pierwill opened this issue Nov 6, 2021 · 3 comments · Fixed by #90731
Closed

Consider removing rustc_incremental::persist::fs::dep_graph_path_from #90658

pierwill opened this issue Nov 6, 2021 · 3 comments · Fixed by #90731
Assignees
@pierwill
Labels
A-incr-comp Area: Incremental compilation C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@pierwill
Copy link
Member

pierwill commented Nov 6, 2021 •
edited by rustbot
Loading

This function is only used once, with the current session's directory. Is there a reason to keep it, or should it be replaced by dep_graph_path?

Originally posted by @cjgillot in #90407 (comment)
@pierwill
Copy link
Member Author

pierwill commented Nov 6, 2021

@rustbot label +A-incr-comp +C-cleanup

@rustbot rustbot added A-incr-comp Area: Incremental compilation C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Nov 6, 2021
@michaelwoerister
Copy link
Member

@pierwill, feel free to make a PR and r? me on it.

@pierwill
Copy link
Member Author

pierwill commented Nov 9, 2021

@rustbot claim

@pierwill pierwill mentioned this issue Nov 9, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 11, 2021
@matthiaskrgr
Rollup merge of rust-lang#90731 - pierwill:fix-90658, r=michaelwoerister
e0fbf11 
Remove `rustc_incremental::persist::fs::dep_graph_path_from`

Closes rust-lang#90658.

r? `@michaelwoerister`
the8472 added a commit to the8472/rust that referenced this issue Nov 11, 2021
@the8472
Rollup merge of rust-lang#90731 - pierwill:fix-90658, r=michaelwoerister
81cf805 
Remove `rustc_incremental::persist::fs::dep_graph_path_from`

Closes rust-lang#90658.

r? ``@michaelwoerister``
@bors bors closed this as completed in e4c23da Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierwill pierwill

Labels
A-incr-comp Area: Incremental compilation C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove rustc_incremental::persist::fs::dep_graph_path_from pierwill/rust
3 participants
@michaelwoerister @pierwill @rustbot