Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unwinding for Windows #908

Closed
brson opened this issue Sep 12, 2011 · 8 comments
Closed

Implement unwinding for Windows #908

brson opened this issue Sep 12, 2011 · 8 comments
Labels
A-codegen Area: Code generation A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows O-windows Operating system: Windows

Comments

@brson
Copy link
Contributor

brson commented Sep 12, 2011

Windows can't unwind on task failure because LLVM exception handling doesn't work there.
@brson brson mentioned this issue Oct 27, 2011
Closed
@brson
Copy link
Contributor Author

brson commented Nov 15, 2011

http://llvm.org/bugs/show_bug.cgi?id=11285

@ghost ghost assigned brson Mar 15, 2012
@bblum
Copy link
Contributor

bblum commented Jul 20, 2012

Reassigning the "Application has requested the Runtime to terminate it in an abnormal way" FIXME in rust_kernel::fail to this bug, 'cause it's related to failure on windows, so I can close #2671.

bblum added a commit that referenced this issue Jul 20, 2012
@bblum
[4/4 for #2365, #2671] Reassign one last fixme to #908. Close #2365. C…
3dc52da 
…lose #2671.
@brson brson mentioned this issue Dec 4, 2012
Closed
@sanxiyn sanxiyn mentioned this issue Mar 7, 2013
Closed
@pnkfelix
Copy link
Member

Not critical for 0.6; de-milestoning

@bstrie
Copy link
Contributor

bstrie commented May 6, 2013

Nominating for Maturity 3.

@graydon
Copy link
Contributor

graydon commented May 30, 2013

accepted for feature-complete milestone

@brson brson mentioned this issue Jul 22, 2013
Closed
@thadguidry
Copy link
Contributor

Some LLVM patches exist for simple Windows 64 Exception Handling support in LLVM. See LLVMdev message http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-April/060838.html

@bblum bblum mentioned this issue Jul 24, 2013
Closed
@vadimcn vadimcn mentioned this issue Aug 18, 2013
Closed
bors added a commit that referenced this issue Aug 23, 2013
@bors
auto merge of #8596 : vadimcn/rust/master, r=alexcrichton
9e1e152 
This resolves issue #908.  

Notable changes:
-  On Windows, LLVM integrated assembler emits bad stack unwind tables when segmented stacks are enabled.  However, unwind info directives in the assembly output are correct, so we generate assembly first and then run it through an external assembler, just like it is already done for Android builds.

- Linker is invoked  via "g++" command instead of "gcc": g++ passes the appropriate magic parameters to the linker, which ensure correct registration of stack unwind tables in dynamic libraries.
@vadimcn
Copy link
Contributor

vadimcn commented Aug 28, 2013

This can be closed now.

@alexcrichton
Copy link
Member

hurrah!

arielb1 pushed a commit to arielb1/rust that referenced this issue Apr 10, 2015
@alexcrichton
Merge pull request rust-lang#908 from llogiq/master
b906439 
Update 0840-no-panic-in-c-string.md
@venkag venkag mentioned this issue Feb 13, 2019
Closed
bors pushed a commit to rust-lang-ci/rust that referenced this issue Oct 26, 2020
@dependabot-preview
Bump proc-macro2 from 1.0.8 to 1.0.9 (rust-lang#908)
c53297f 
Bumps [proc-macro2](https://github.com/alexcrichton/proc-macro2) from 1.0.8 to 1.0.9.
- [Release notes](https://github.com/alexcrichton/proc-macro2/releases)
- [Commits](dtolnay/proc-macro2@1.0.8...1.0.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@wsmoses
Custom alloc zeroing (rust-lang#908)
c1a1f22 
* Custom zero

* Enable on differentials

* Cleanup
coastalwhite pushed a commit to coastalwhite/rust that referenced this issue Aug 5, 2023
@thomcc
Optimize std_detect's caching (rust-lang#908)
291395d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@graydon @alexcrichton @brson @pnkfelix @bstrie @thadguidry @bblum @vadimcn